From: khali@linux-fr.org (Jean Delvare)
To: Andreas Dilger <adilger@clusterfs.com>
Cc: jthiessen@penguincomputing.com, sensors@Stimpy.netroedge.com,
linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Ticket #1851 - PATCH (take 2) for adm1026.c, kernel 2.6.10-bk6
Date: Thu, 19 May 2005 06:25:28 +0000 [thread overview]
Message-ID: <20050103221014.381efab7.khali@linux-fr.org> (raw)
In-Reply-To: <20050103205231.GK9923@schnapps.adilger.int>
> Also, on a completely "I don't know what the hell I'm talking about"
> point, it seems odd that for values named "0_3" and "4_7" you would
> upshift the "4_7" value 8 bits instead of 4, but it could be just a
> bad choice of variable names.
Actually each divider is stored on 2 bits, so both the names and the
shift look OK to me.
--
Jean Delvare
http://khali.linux-fr.org/
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: jthiessen@penguincomputing.com, sensors@Stimpy.netroedge.com,
linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: Ticket #1851 - PATCH (take 2) for adm1026.c, kernel 2.6.10-bk6
Date: Mon, 3 Jan 2005 22:10:14 +0100 [thread overview]
Message-ID: <20050103221014.381efab7.khali@linux-fr.org> (raw)
In-Reply-To: <20050103205231.GK9923@schnapps.adilger.int>
> Also, on a completely "I don't know what the hell I'm talking about"
> point, it seems odd that for values named "0_3" and "4_7" you would
> upshift the "4_7" value 8 bits instead of 4, but it could be just a
> bad choice of variable names.
Actually each divider is stored on 2 bits, so both the names and the
shift look OK to me.
--
Jean Delvare
http://khali.linux-fr.org/
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 Ticket #1851 Mark Studebaker
2005-05-19 6:25 ` Jean Delvare
2005-01-03 19:43 ` Ticket #1851 - PATCH for adm1026.c, kernel 2.6.10-bk6 Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-03 19:10 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-03 21:37 ` Ticket #1851 - PATCH (take 2) " Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-03 20:52 ` Andreas Dilger
2005-05-19 6:25 ` Andreas Dilger
2005-01-03 21:10 ` Jean Delvare [this message]
2005-05-19 6:25 ` Jean Delvare
2005-01-03 22:12 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-12 18:50 ` PATCH (take 3) for adm1026.c, kernel 2.6.10-bk14 Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-12 18:55 ` Greg KH
2005-05-19 6:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050103221014.381efab7.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=adilger@clusterfs.com \
--cc=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.