From: greg@kroah.com (Greg KH)
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: LM Sensors <sensors@Stimpy.netroedge.com>,
LKML <linux-kernel@vger.kernel.org>,
khali@linux-fr.org
Subject: PATCH (take 3) for adm1026.c, kernel 2.6.10-bk14
Date: Thu, 19 May 2005 06:25:30 +0000 [thread overview]
Message-ID: <20050112185513.GB10687@kroah.com> (raw)
In-Reply-To: <20050112185055.GB16724@penguincomputing.com>
On Wed, Jan 12, 2005 at 10:50:55AM -0800, Justin Thiessen wrote:
> Ok, take 3 on the adm1026 patch.
>
> In this patch:
>
> (1) Code has been added which ensures that the fan divisor registers are
> properly read into the data structure before fan minimum speeds are
> determined. This prevents a possible divide by zero error. The line
> which reads the hardware default fan divisor values has been reformatted
> as suggested by Andreas Dilger to make the intent of the statement clearer.
>
> (2) In a similar spirit, an unecessary carriage return from a "dev_dbg"
> statement in the adm1026_print_gpio() function has been elminated,
> shortening the statement to a single line and making the code easier
> to read.
>
> Signed-off-by: Justin Thiessen <jthiessen@penguincomputing.com
Applied, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: LM Sensors <sensors@Stimpy.netroedge.com>,
LKML <linux-kernel@vger.kernel.org>,
khali@linux-fr.org
Subject: Re: PATCH (take 3) for adm1026.c, kernel 2.6.10-bk14
Date: Wed, 12 Jan 2005 10:55:13 -0800 [thread overview]
Message-ID: <20050112185513.GB10687@kroah.com> (raw)
In-Reply-To: <20050112185055.GB16724@penguincomputing.com>
On Wed, Jan 12, 2005 at 10:50:55AM -0800, Justin Thiessen wrote:
> Ok, take 3 on the adm1026 patch.
>
> In this patch:
>
> (1) Code has been added which ensures that the fan divisor registers are
> properly read into the data structure before fan minimum speeds are
> determined. This prevents a possible divide by zero error. The line
> which reads the hardware default fan divisor values has been reformatted
> as suggested by Andreas Dilger to make the intent of the statement clearer.
>
> (2) In a similar spirit, an unecessary carriage return from a "dev_dbg"
> statement in the adm1026_print_gpio() function has been elminated,
> shortening the statement to a single line and making the code easier
> to read.
>
> Signed-off-by: Justin Thiessen <jthiessen@penguincomputing.com
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 Ticket #1851 Mark Studebaker
2005-05-19 6:25 ` Jean Delvare
2005-01-03 19:43 ` Ticket #1851 - PATCH for adm1026.c, kernel 2.6.10-bk6 Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-03 19:10 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-03 21:37 ` Ticket #1851 - PATCH (take 2) " Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-03 20:52 ` Andreas Dilger
2005-05-19 6:25 ` Andreas Dilger
2005-01-03 21:10 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-03 22:12 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-12 18:50 ` PATCH (take 3) for adm1026.c, kernel 2.6.10-bk14 Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-01-12 18:55 ` Greg KH [this message]
2005-05-19 6:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112185513.GB10687@kroah.com \
--to=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.