[KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups

[KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

On 04/01/05 13:56 -0800, jlamanna@gmail.com wrote:
> -		if (db->dict) {
> -			vfree (db->dict);
> -			db->dict -		}
> +		vfree (db->dict);
> +		db->dict  

Khm... mailer problems with '='?
Please fix this (encoding settings?) and resend.
Also: you can test your mail is fine by sending it to youself and
feeding it to `patch`.

Other than this, patches look fine to me.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups

[James Lamanna]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Oh wow.
I must have missed that strangeness.
I'll send new ones shortly.


On Tue, 4 Jan 2005 23:47:29 +0100, Domen Puncer <domen@coderock.org> wrote:
> On 04/01/05 13:56 -0800, jlamanna@gmail.com wrote:
> > -             if (db->dict) {
> > -                     vfree (db->dict);
> > -                     db->dict -              }
> > +             vfree (db->dict);
> > +             db->dict
> 
> Khm... mailer problems with '='?
> Please fix this (encoding settings?) and resend.
> Also: you can test your mail is fine by sending it to youself and
> feeding it to `patch`.
> 
> Other than this, patches look fine to me.
> 
> 
>         Domen
>

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors