All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups
@ 2005-01-04 22:47 Domen Puncer
  2005-01-04 23:01 ` James Lamanna
  0 siblings, 1 reply; 2+ messages in thread
From: Domen Puncer @ 2005-01-04 22:47 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

On 04/01/05 13:56 -0800, jlamanna@gmail.com wrote:
> -		if (db->dict) {
> -			vfree (db->dict);
> -			db->dict -		}
> +		vfree (db->dict);
> +		db->dict  

Khm... mailer problems with '='?
Please fix this (encoding settings?) and resend.
Also: you can test your mail is fine by sending it to youself and
feeding it to `patch`.

Other than this, patches look fine to me.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups
  2005-01-04 22:47 [KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups Domen Puncer
@ 2005-01-04 23:01 ` James Lamanna
  0 siblings, 0 replies; 2+ messages in thread
From: James Lamanna @ 2005-01-04 23:01 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Oh wow.
I must have missed that strangeness.
I'll send new ones shortly.


On Tue, 4 Jan 2005 23:47:29 +0100, Domen Puncer <domen@coderock.org> wrote:
> On 04/01/05 13:56 -0800, jlamanna@gmail.com wrote:
> > -             if (db->dict) {
> > -                     vfree (db->dict);
> > -                     db->dict -              }
> > +             vfree (db->dict);
> > +             db->dict
> 
> Khm... mailer problems with '='?
> Please fix this (encoding settings?) and resend.
> Also: you can test your mail is fine by sending it to youself and
> feeding it to `patch`.
> 
> Other than this, patches look fine to me.
> 
> 
>         Domen
>

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-04 23:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-04 22:47 [KJ] Re: isdn_bsdcomp.c - vfree() checking cleanups Domen Puncer
2005-01-04 23:01 ` James Lamanna

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.