From: greg@kroah.com (Greg KH)
To: Jonas Munsin <jmunsin@iki.fi>, Jean Delvare <khali@linux-fr.org>,
pioppo@ferrara.linux.it, sensors@Stimpy.netroedge.com,
djg@pdp8.net, LKML <linux-kernel@vger.kernel.org>
Subject: 2.6.10-mm2: it87 sensor driver stops CPU fan
Date: Thu, 19 May 2005 06:25:30 +0000 [thread overview]
Message-ID: <20050113232904.GC2458@kroah.com> (raw)
In-Reply-To: <20050112222735.GA13572@nemo.sby.abo.fi>
On Thu, Jan 13, 2005 at 12:27:35AM +0200, Jonas Munsin wrote:
> > 2* I would then add a check to the it87 driver, which completely disables
> > the fan speed control interface if the initial configuration looks weird
> > (all fans supposedly stopped and polarity set to "active low"). This
> > should protect users of the driver who have a faulty BIOS.
> >
> > When a bogus configuration is detected, we would of course complain in
> > the logs and invite the user to complain to his/her motherboard maker
> > too.
>
> Here is it87.c_2.6.10-jm4-detect_broken_bios_20050112.diff implementing
> this. It goes on top of the previous patch.
>
> - detects broken bioses, disables the pwm for them and prints a message
> - fixes an unrelated minor bug in set_fan_div()
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Jonas Munsin <jmunsin@iki.fi>
Applied, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Jonas Munsin <jmunsin@iki.fi>, Jean Delvare <khali@linux-fr.org>,
pioppo@ferrara.linux.it, sensors@Stimpy.netroedge.com,
djg@pdp8.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.10-mm2: it87 sensor driver stops CPU fan
Date: Thu, 13 Jan 2005 15:29:04 -0800 [thread overview]
Message-ID: <20050113232904.GC2458@kroah.com> (raw)
In-Reply-To: <20050112222735.GA13572@nemo.sby.abo.fi>
On Thu, Jan 13, 2005 at 12:27:35AM +0200, Jonas Munsin wrote:
> > 2* I would then add a check to the it87 driver, which completely disables
> > the fan speed control interface if the initial configuration looks weird
> > (all fans supposedly stopped and polarity set to "active low"). This
> > should protect users of the driver who have a faulty BIOS.
> >
> > When a bogus configuration is detected, we would of course complain in
> > the logs and invite the user to complain to his/her motherboard maker
> > too.
>
> Here is it87.c_2.6.10-jm4-detect_broken_bios_20050112.diff implementing
> this. It goes on top of the previous patch.
>
> - detects broken bioses, disables the pwm for them and prints a message
> - fixes an unrelated minor bug in set_fan_div()
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Jonas Munsin <jmunsin@iki.fi>
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-08 0:50 2.6.10-mm2: it87 sensor driver stops CPU fan Simone Piunno
2005-01-08 9:34 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-10 22:41 ` Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-11 9:26 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-11 20:24 ` Jonas Munsin
2005-05-19 6:25 ` Jonas Munsin
2005-01-11 20:56 ` Jean Delvare
2005-01-11 22:41 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-01-11 21:04 ` Simone Piunno
2005-01-12 9:44 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-12 22:27 ` Jonas Munsin
2005-05-19 6:25 ` Jonas Munsin
2005-01-13 23:29 ` Greg KH [this message]
2005-05-19 6:25 ` Greg KH
2005-01-14 14:40 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-15 15:30 ` [PATCH 2.6] I2C: Allow it87 pwm reconfiguration Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-15 17:18 ` Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-19 23:23 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-01-15 15:54 ` 2.6.10-mm2: it87 sensor driver stops CPU fan Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-15 16:55 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-16 22:32 ` Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-17 19:19 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-17 19:37 ` 2.6 Series Mem Mgmt Chris Bookholt
2005-01-17 19:56 ` Brian Gerst
2005-01-08 16:20 ` 2.6.10-mm2: it87 sensor driver stops CPU fan Jean Delvare
2005-01-08 19:23 ` Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-10 19:23 ` Simone Piunno
2005-05-19 6:25 ` Simone Piunno
2005-01-10 19:34 ` Jean Delvare
2005-01-19 20:19 ` Nicolas Pitre
2005-05-19 6:25 ` Nicolas Pitre
2005-01-19 20:52 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-19 22:10 ` Nicolas Pitre
2005-05-19 6:25 ` Nicolas Pitre
2005-01-20 11:08 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-20 16:01 ` Nicolas Pitre
2005-05-19 6:25 ` Nicolas Pitre
2005-01-20 16:28 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-20 21:19 ` Nicolas Pitre
2005-05-19 6:25 ` Nicolas Pitre
2005-01-21 6:46 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050113232904.GC2458@kroah.com \
--to=greg@kroah.com \
--cc=djg@pdp8.net \
--cc=jmunsin@iki.fi \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pioppo@ferrara.linux.it \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.