From: Nishanth Aravamudan <nacc@us.ibm.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, kernel-janitors@lists.osdl.org
Subject: [KJ] [PATCH 26/34] mips/mirage_ts: replace
Date: Wed, 26 Jan 2005 00:26:48 +0000 [thread overview]
Message-ID: <20050126002648.GR12649@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
Hi,
Please consider applying.
Description: Use wait_event_timeout() instead of the deprecated
interruptible_sleep_on_timeout(). The current code does not seem to
care about signals, so interruptible seems unnecessary.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 09:28:12.000000000 -0800
+++ 2.6.11-rc2-kj/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 16:43:25.000000000 -0800
@@ -42,6 +42,7 @@
#include <linux/proc_fs.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
+#include <linux/wait.h>
#include <asm/segment.h>
#include <asm/irq.h>
@@ -147,10 +148,7 @@ static int ts_thread(void *id)
ts = wm97xx_ts_get_handle(0);
/* proceed only after everybody is ready */
- while ( ! wm97xx_ts_ready(ts) ) {
- /* give a little time for initializations to complete */
- interruptible_sleep_on_timeout(&pendown_wait, HZ / 4);
- }
+ wait_event_timeout(pendown_wait, wm97xx_ts_ready(ts), HZ/4);
/* board-specific calibration */
wm97xx_ts_set_cal(ts,
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, kernel-janitors@lists.osdl.org
Subject: [PATCH 26/34] mips/mirage_ts: replace interruptible_sleep_on_timeout() with wait_event_timeout()
Date: Tue, 25 Jan 2005 16:26:48 -0800 [thread overview]
Message-ID: <20050126002648.GR12649@us.ibm.com> (raw)
Hi,
Please consider applying.
Description: Use wait_event_timeout() instead of the deprecated
interruptible_sleep_on_timeout(). The current code does not seem to
care about signals, so interruptible seems unnecessary.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 09:28:12.000000000 -0800
+++ 2.6.11-rc2-kj/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 16:43:25.000000000 -0800
@@ -42,6 +42,7 @@
#include <linux/proc_fs.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
+#include <linux/wait.h>
#include <asm/segment.h>
#include <asm/irq.h>
@@ -147,10 +148,7 @@ static int ts_thread(void *id)
ts = wm97xx_ts_get_handle(0);
/* proceed only after everybody is ready */
- while ( ! wm97xx_ts_ready(ts) ) {
- /* give a little time for initializations to complete */
- interruptible_sleep_on_timeout(&pendown_wait, HZ / 4);
- }
+ wait_event_timeout(pendown_wait, wm97xx_ts_ready(ts), HZ/4);
/* board-specific calibration */
wm97xx_ts_set_cal(ts,
next reply other threads:[~2005-01-26 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-26 0:26 Nishanth Aravamudan [this message]
2005-01-26 0:26 ` [PATCH 26/34] mips/mirage_ts: replace interruptible_sleep_on_timeout() with wait_event_timeout() Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050126002648.GR12649@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.