* [KJ] [PATCH 26/34] mips/mirage_ts: replace
@ 2005-01-26 0:26 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2005-01-26 0:26 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
Hi,
Please consider applying.
Description: Use wait_event_timeout() instead of the deprecated
interruptible_sleep_on_timeout(). The current code does not seem to
care about signals, so interruptible seems unnecessary.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 09:28:12.000000000 -0800
+++ 2.6.11-rc2-kj/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 16:43:25.000000000 -0800
@@ -42,6 +42,7 @@
#include <linux/proc_fs.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
+#include <linux/wait.h>
#include <asm/segment.h>
#include <asm/irq.h>
@@ -147,10 +148,7 @@ static int ts_thread(void *id)
ts = wm97xx_ts_get_handle(0);
/* proceed only after everybody is ready */
- while ( ! wm97xx_ts_ready(ts) ) {
- /* give a little time for initializations to complete */
- interruptible_sleep_on_timeout(&pendown_wait, HZ / 4);
- }
+ wait_event_timeout(pendown_wait, wm97xx_ts_ready(ts), HZ/4);
/* board-specific calibration */
wm97xx_ts_set_cal(ts,
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 26/34] mips/mirage_ts: replace interruptible_sleep_on_timeout() with wait_event_timeout()
@ 2005-01-26 0:26 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2005-01-26 0:26 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, kernel-janitors
Hi,
Please consider applying.
Description: Use wait_event_timeout() instead of the deprecated
interruptible_sleep_on_timeout(). The current code does not seem to
care about signals, so interruptible seems unnecessary.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 09:28:12.000000000 -0800
+++ 2.6.11-rc2-kj/arch/mips/au1000/db1x00/mirage_ts.c 2005-01-24 16:43:25.000000000 -0800
@@ -42,6 +42,7 @@
#include <linux/proc_fs.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
+#include <linux/wait.h>
#include <asm/segment.h>
#include <asm/irq.h>
@@ -147,10 +148,7 @@ static int ts_thread(void *id)
ts = wm97xx_ts_get_handle(0);
/* proceed only after everybody is ready */
- while ( ! wm97xx_ts_ready(ts) ) {
- /* give a little time for initializations to complete */
- interruptible_sleep_on_timeout(&pendown_wait, HZ / 4);
- }
+ wait_event_timeout(pendown_wait, wm97xx_ts_ready(ts), HZ/4);
/* board-specific calibration */
wm97xx_ts_set_cal(ts,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-26 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-26 0:26 [KJ] [PATCH 26/34] mips/mirage_ts: replace Nishanth Aravamudan
2005-01-26 0:26 ` [PATCH 26/34] mips/mirage_ts: replace interruptible_sleep_on_timeout() with wait_event_timeout() Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.