All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Roman Zippel <zippel@linux-m68k.org>,
	Andries Brouwer <aebr@win.tue.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: Possible bug in keyboard.c (2.6.10)
Date: Sat, 29 Jan 2005 04:50:55 +0000	[thread overview]
Message-ID: <20050129045055.GS8859@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050128105937.GA5963@ucw.cz>

On Fri, Jan 28, 2005 at 11:59:37AM +0100, Vojtech Pavlik wrote:
> I'm very sorry about the locking, but the thing grew up in times of
> kernel 2.0, which didn't require any locking. There are a few possible

Incorrect.  You have blocking allocations in critical areas and they
required locking all way back.

> races with device registration/unregistration, and it's on my list to
> fix that, however under normal operation there shouldn't be any need for
> locks, as there are no complex structures built that'd become
> inconsistent. 

Um-hm...  Vojtech, meet USB mouse; USB mouse, meet Vojtech.  Now watch
a disconnect and reconnect happening when luser suddenly gets overexcited
and jerks the wrong hand a bit too hard while browsing the most profitable
sort of website...

> If you find scenarios which will lead to trouble in the event delivery
> system, please tell me, and I'll try to fix that as soon as possible.

See above.  Devices appearing and disappearing *are* normal.  

  reply	other threads:[~2005-01-29  4:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-27  3:16 Possible bug in keyboard.c (2.6.10) Sasa Stevanovic
2005-01-27  4:50 ` Dmitry Torokhov
2005-01-27 10:16   ` Sasa Stevanovic
2005-01-27 12:56 ` Andries Brouwer
2005-01-28  0:39   ` Roman Zippel
2005-01-28 10:59     ` Vojtech Pavlik
2005-01-29  4:50       ` Al Viro [this message]
2005-01-29 11:25         ` Vojtech Pavlik
2005-01-29 23:35           ` Dmitry Torokhov
2005-01-31  9:01             ` Vojtech Pavlik
2005-01-30  8:41           ` Al Viro
2005-01-30 23:21             ` Dmitry Torokhov
2005-01-30 23:29               ` Dmitry Torokhov
2005-02-03  6:54               ` Dmitry Torokhov
2005-01-29 12:11       ` Roman Zippel
2005-01-29 14:04         ` Vojtech Pavlik
2005-01-30 20:13           ` Roman Zippel
2005-01-28 11:10     ` Vojtech Pavlik
2005-01-28 21:59       ` Andries Brouwer
2005-01-29 11:12         ` Vojtech Pavlik
2005-01-29 23:30           ` Dmitry Torokhov
2005-01-30 23:16     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050129045055.GS8859@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=aebr@win.tue.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.