All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6/9] Use netdev_priv in baycom_ser_hdx driver
@ 2005-01-30 21:33 Ralf Baechle DL5RB
  0 siblings, 0 replies; only message in thread
From: Ralf Baechle DL5RB @ 2005-01-30 21:33 UTC (permalink / raw)
  To: linux-hams; +Cc: Jeff Garzik

Eleminate the last remaining instance of a direct reference to the priv
member of struct net_device.  This was debug code only, so use BUG_ON()
instead of printk.

 baycom_ser_hdx.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Index: bk-afu/drivers/net/hamradio/baycom_ser_hdx.c
===================================================================
--- bk-afu.orig/drivers/net/hamradio/baycom_ser_hdx.c
+++ bk-afu/drivers/net/hamradio/baycom_ser_hdx.c
@@ -570,12 +570,11 @@
 	struct baycom_state *bc;
 	struct baycom_ioctl bi;
 
-	if (!dev || !dev->priv ||
-	    ((struct baycom_state *)dev->priv)->hdrv.magic != HDLCDRV_MAGIC) {
-		printk(KERN_ERR "bc_ioctl: invalid device struct\n");
+	if (!dev)
 		return -EINVAL;
-	}
+
 	bc = netdev_priv(dev);
+	BUG_ON(bc->hdrv.magic != HDLCDRV_MAGIC);
 
 	if (cmd != SIOCDEVPRIVATE)
 		return -ENOIOCTLCMD;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-01-30 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-30 21:33 [PATCH 6/9] Use netdev_priv in baycom_ser_hdx driver Ralf Baechle DL5RB

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.