All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: Aur?lien Jarno <aurelien@aurel32.net>,
	sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6] I2C: New chip driver: sis5595
Date: Thu, 19 May 2005 06:25:34 +0000	[thread overview]
Message-ID: <20050131182148.GA21438@kroah.com> (raw)
In-Reply-To: <20050125220945.GA23560@bode.aurel32.net>

On Tue, Jan 25, 2005 at 11:09:45PM +0100, Aur?lien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> +	u16 val;
> +	int *i;
> +
> +	if (!(s_bridge > +	    pci_find_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))

Please use pci_get_device().  It's safer, and not a depreciated
function.

> +	/* Look for imposters */
> +	for(i = blacklist; *i != 0; i++) {
> +		if (pci_find_device(PCI_VENDOR_ID_SI, *i, NULL)) {

Same here.

> +			printk("sis5595.ko: Error: Looked for SIS5595 but found unsupported device %.4X\n", *i);

<snip>

> +		printk("sis5595.ko: base address not set - upgrade BIOS or use force_addr=0xaddr\n");

These printk() calls need a KERN_ level.  Why not use the dev_* calls
instead?  You have a pci_dev to use here, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Aur?lien Jarno <aurelien@aurel32.net>,
	sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] I2C: New chip driver: sis5595
Date: Mon, 31 Jan 2005 10:21:48 -0800	[thread overview]
Message-ID: <20050131182148.GA21438@kroah.com> (raw)
In-Reply-To: <20050125220945.GA23560@bode.aurel32.net>

On Tue, Jan 25, 2005 at 11:09:45PM +0100, Aur?lien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> +	u16 val;
> +	int *i;
> +
> +	if (!(s_bridge =
> +	    pci_find_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))

Please use pci_get_device().  It's safer, and not a depreciated
function.

> +	/* Look for imposters */
> +	for(i = blacklist; *i != 0; i++) {
> +		if (pci_find_device(PCI_VENDOR_ID_SI, *i, NULL)) {

Same here.

> +			printk("sis5595.ko: Error: Looked for SIS5595 but found unsupported device %.4X\n", *i);

<snip>

> +		printk("sis5595.ko: base address not set - upgrade BIOS or use force_addr=0xaddr\n");

These printk() calls need a KERN_ level.  Why not use the dev_* calls
instead?  You have a pci_dev to use here, right?

thanks,

greg k-h

  reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-25 22:09 [PATCH 2.6] I2C: New chip driver: sis5595 Aurélien Jarno
2005-05-19  6:25 ` Aurélien Jarno
2005-01-31 18:21 ` Greg KH [this message]
2005-05-19  6:25   ` Greg KH
2005-02-01 10:11   ` Aurelien Jarno
2005-05-19  6:25     ` Aurelien Jarno
  -- strict thread matches above, loose matches on Subject: below --
2005-02-01 12:20 Alexey Dobriyan
2005-05-19  6:25 ` Alexey Dobriyan
2005-02-01 11:49 ` Jean Delvare
2005-05-19  6:25   ` Jean Delvare
2005-02-01 14:12   ` Alexey Dobriyan
2005-05-19  6:25     ` Alexey Dobriyan
2005-02-01 13:52     ` Jean Delvare
2005-05-19  6:25       ` Jean Delvare
2005-02-01 14:43       ` Jean Delvare
2005-05-19  6:25         ` Jean Delvare
2005-02-01 16:57       ` Alexey Dobriyan
2005-05-19  6:25         ` Alexey Dobriyan
2005-02-01 16:42         ` Jean Delvare
2005-05-19  6:25           ` Jean Delvare
2005-02-01 12:14 ` Aurelien Jarno
2005-05-19  6:25   ` Aurelien Jarno
2005-02-01 16:54   ` Greg KH
2005-05-19  6:25     ` Greg KH
2005-02-01 17:00     ` Jean Delvare
2005-05-19  6:25       ` Jean Delvare
2005-02-01 16:55   ` Greg KH
2005-05-19  6:25     ` Greg KH
2005-02-06 20:26 [PATCH 2.6] I2C: New chip driver: sis5595 (resubmit) Aurélien Jarno
2005-05-19  6:25 ` Aurélien Jarno
2005-02-17 22:25 ` Greg KH
2005-05-19  6:25   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050131182148.GA21438@kroah.com \
    --to=greg@kroah.com \
    --cc=aurelien@aurel32.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.