From: greg@kroah.com (Greg KH)
To: Aurelien Jarno <aurelien@aurel32.net>,
Alexey Dobriyan <adobriyan@mail.ru>,
linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com
Subject: [PATCH 2.6] I2C: New chip driver: sis5595
Date: Thu, 19 May 2005 06:25:35 +0000 [thread overview]
Message-ID: <20050201165434.GD23118@kroah.com> (raw)
In-Reply-To: <20050201121414.GA15219@bode.aurel32.net>
On Tue, Feb 01, 2005 at 01:14:14PM +0100, Aurelien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> + u16 val;
> + int *i;
> +
> + if (!(s_bridge > + pci_get_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))
> + return -ENODEV;
You never free the reference you grabbed on the pci_dev here. Please
read the docs on how pci_get_device() is to be used, it isn't just a
drop in replacement for pci_find_device(), sorry.
> + /* Look for imposters */
> + for(i = blacklist; *i != 0; i++) {
> + if (pci_get_device(PCI_VENDOR_ID_SI, *i, NULL)) {
Same here, you are leaking a reference count.
Why are you not using the pci driver interface instead?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Aurelien Jarno <aurelien@aurel32.net>,
Alexey Dobriyan <adobriyan@mail.ru>,
linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com
Subject: Re: [PATCH 2.6] I2C: New chip driver: sis5595
Date: Tue, 1 Feb 2005 08:54:34 -0800 [thread overview]
Message-ID: <20050201165434.GD23118@kroah.com> (raw)
In-Reply-To: <20050201121414.GA15219@bode.aurel32.net>
On Tue, Feb 01, 2005 at 01:14:14PM +0100, Aurelien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> + u16 val;
> + int *i;
> +
> + if (!(s_bridge =
> + pci_get_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))
> + return -ENODEV;
You never free the reference you grabbed on the pci_dev here. Please
read the docs on how pci_get_device() is to be used, it isn't just a
drop in replacement for pci_find_device(), sorry.
> + /* Look for imposters */
> + for(i = blacklist; *i != 0; i++) {
> + if (pci_get_device(PCI_VENDOR_ID_SI, *i, NULL)) {
Same here, you are leaking a reference count.
Why are you not using the pci driver interface instead?
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 12:20 [PATCH 2.6] I2C: New chip driver: sis5595 Alexey Dobriyan
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-01 11:49 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-01 14:12 ` Alexey Dobriyan
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-01 13:52 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-01 14:43 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-01 16:57 ` Alexey Dobriyan
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-01 16:42 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-01 12:14 ` Aurelien Jarno
2005-05-19 6:25 ` Aurelien Jarno
2005-02-01 16:54 ` Greg KH [this message]
2005-05-19 6:25 ` Greg KH
2005-02-01 17:00 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-01 16:55 ` Greg KH
2005-05-19 6:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-02-06 20:26 [PATCH 2.6] I2C: New chip driver: sis5595 (resubmit) Aurélien Jarno
2005-05-19 6:25 ` Aurélien Jarno
2005-02-17 22:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-01-25 22:09 [PATCH 2.6] I2C: New chip driver: sis5595 Aurélien Jarno
2005-05-19 6:25 ` Aurélien Jarno
2005-01-31 18:21 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-02-01 10:11 ` Aurelien Jarno
2005-05-19 6:25 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050201165434.GD23118@kroah.com \
--to=greg@kroah.com \
--cc=adobriyan@mail.ru \
--cc=aurelien@aurel32.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.