[KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout()

[KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout()

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Fri, Jan 21, 2005 at 01:36:35PM -0800, Nishanth Aravamudan wrote:
> Hi,
> 
> Please consider applying.
> 
> Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> now unused variables. I changed the code to only add to the wait-queue if
> necessary, but I'm not sure if this is correct.

Please at least compile your patches to make sure they build.  This one
does not :(

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Mon, Jan 31, 2005 at 10:51:59AM -0800, Greg KH wrote:
> On Fri, Jan 21, 2005 at 01:36:35PM -0800, Nishanth Aravamudan wrote:
> > Hi,
> > 
> > Please consider applying.
> > 
> > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > now unused variables. I changed the code to only add to the wait-queue if
> > necessary, but I'm not sure if this is correct.
> 
> Please at least compile your patches to make sure they build.  This one
> does not :(

I'm not seeing a build error here; what errors are coming up for you?

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout()

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

On Mon, Jan 31, 2005 at 11:27:03AM -0800, Nishanth Aravamudan wrote:
> On Mon, Jan 31, 2005 at 10:51:59AM -0800, Greg KH wrote:
> > On Fri, Jan 21, 2005 at 01:36:35PM -0800, Nishanth Aravamudan wrote:
> > > Hi,
> > > 
> > > Please consider applying.
> > > 
> > > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > > now unused variables. I changed the code to only add to the wait-queue if
> > > necessary, but I'm not sure if this is correct.
> > 
> > Please at least compile your patches to make sure they build.  This one
> > does not :(
> 
> I'm not seeing a build error here; what errors are coming up for you?

Don't remember anymore, as I reverted the patch already...

I think it was a {} matching issue like your other patches.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors