From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH 19/20] bluetooth/bluecard_cs: remove
Date: Wed, 02 Feb 2005 22:58:55 +0000 [thread overview]
Message-ID: <20050202225855.GY2546@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
Hello,
Please consider applying.
Description: Remove deprecated interruptible_sleep_on_timeout() function calls
and replace with direct wait-queue usage. Some naming conflicts occurred, which
I tried to resolve appropriately. Patch is compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/drivers/bluetooth/bluecard_cs.c 2005-01-24 09:34:04.000000000 -0800
+++ 2.6.11-rc2-kj/drivers/bluetooth/bluecard_cs.c 2005-02-02 14:57:24.000000000 -0800
@@ -35,6 +35,7 @@
#include <linux/ioport.h>
#include <linux/spinlock.h>
#include <linux/moduleparam.h>
+#include <linux/wait.h>
#include <linux/skbuff.h>
#include <asm/io.h>
@@ -289,8 +290,8 @@ static void bluecard_write_wakeup(blueca
clear_bit(ready_bit, &(info->tx_state));
if (skb->pkt_type & 0x80) {
-
- wait_queue_head_t wait;
+ DEFINE_WAIT(wait);
+ wait_queue_head_t wq;
unsigned char baud_reg;
switch (skb->pkt_type) {
@@ -311,8 +312,9 @@ static void bluecard_write_wakeup(blueca
}
/* Wait until the command reaches the baseband */
- init_waitqueue_head(&wait);
- interruptible_sleep_on_timeout(&wait, HZ / 10);
+ prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ/10);
+ finish_wait(&wq, &wait);
/* Set baud on baseband */
info->ctrl_reg &= ~0x03;
@@ -324,8 +326,9 @@ static void bluecard_write_wakeup(blueca
outb(info->ctrl_reg, iobase + REG_CONTROL);
/* Wait before the next HCI packet can be send */
- interruptible_sleep_on_timeout(&wait, HZ);
-
+ prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ);
+ finish_wait(&wq, &wait);
}
if (len == skb->len) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-02-02 22:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-02 22:58 Nishanth Aravamudan [this message]
2005-02-02 23:16 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-02 23:16 ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-03 0:25 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Nishanth Aravamudan
2005-02-03 0:25 ` [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Nishanth Aravamudan
2005-02-05 0:11 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-05 0:11 ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-06 22:19 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Nish Aravamudan
2005-02-06 22:19 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Nish Aravamudan
2005-02-06 22:38 ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-06 22:38 ` [Bluez-devel] Re: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-18 23:43 ` [KJ] Re: bluetooth/bluecard_cs: remove Domen Puncer
2005-02-18 23:43 ` bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050202225855.GY2546@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.