All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	bluez-devel@lists.sourceforge.net,
	kernel-janitors@lists.osdl.org
Subject: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove
Date: Thu, 03 Feb 2005 00:25:02 +0000	[thread overview]
Message-ID: <20050203002502.GB2546@us.ibm.com> (raw)
In-Reply-To: <1107386189.11944.21.camel@pegasus>

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Thu, Feb 03, 2005 at 12:16:29AM +0100, Marcel Holtmann wrote:
> Hi Nish,
> 
> > Please consider applying.
> > 
> > Description: Remove deprecated interruptible_sleep_on_timeout() function calls
> > and replace with direct wait-queue usage. Some naming conflicts occurred, which
> > I tried to resolve appropriately. Patch is compile-tested.
> 
> you introduce more code than you remove. Is our code a special case or
> why don't exists a simple API function as replacement?

Yes, I do. *sleep_on*() was the API, which has been replaced with wait_event*().
However, wait_event*() explicitly needs a condition (the "event"), which in
thise case does not exist. If I had more background, I would have gone the
wait_event*() route. I am looking into a better API to mask away all of the
DEFINE_WAIT(), prepare_to_wait(), schedule()/schedule_timeout(), finish_wait()
additions (the KJ list can attest to how many of these replacements I'm doing),
but there simply does not exist such an API right now.

Any input you could provide, though, would be greatly appreciated.

-Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	bluez-devel@lists.sourceforge.net,
	kernel-janitors@lists.osdl.org
Subject: Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage
Date: Wed, 2 Feb 2005 16:25:02 -0800	[thread overview]
Message-ID: <20050203002502.GB2546@us.ibm.com> (raw)
In-Reply-To: <1107386189.11944.21.camel@pegasus>

On Thu, Feb 03, 2005 at 12:16:29AM +0100, Marcel Holtmann wrote:
> Hi Nish,
> 
> > Please consider applying.
> > 
> > Description: Remove deprecated interruptible_sleep_on_timeout() function calls
> > and replace with direct wait-queue usage. Some naming conflicts occurred, which
> > I tried to resolve appropriately. Patch is compile-tested.
> 
> you introduce more code than you remove. Is our code a special case or
> why don't exists a simple API function as replacement?

Yes, I do. *sleep_on*() was the API, which has been replaced with wait_event*().
However, wait_event*() explicitly needs a condition (the "event"), which in
thise case does not exist. If I had more background, I would have gone the
wait_event*() route. I am looking into a better API to mask away all of the
DEFINE_WAIT(), prepare_to_wait(), schedule()/schedule_timeout(), finish_wait()
additions (the KJ list can attest to how many of these replacements I'm doing),
but there simply does not exist such an API right now.

Any input you could provide, though, would be greatly appreciated.

-Nish

  reply	other threads:[~2005-02-03  0:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 22:58 [KJ] [PATCH 19/20] bluetooth/bluecard_cs: remove Nishanth Aravamudan
2005-02-02 23:16 ` [KJ] " Marcel Holtmann
2005-02-02 23:16   ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-03  0:25   ` Nishanth Aravamudan [this message]
2005-02-03  0:25     ` Nishanth Aravamudan
2005-02-05  0:11     ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-05  0:11       ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-06 22:19       ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Nish Aravamudan
2005-02-06 22:19         ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Nish Aravamudan
2005-02-06 22:38         ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-06 22:38           ` [Bluez-devel] Re: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-18 23:43       ` [KJ] Re: bluetooth/bluecard_cs: remove Domen Puncer
2005-02-18 23:43         ` bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050203002502.GB2546@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=marcel@holtmann.org \
    --cc=maxk@qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.