All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	bluez-devel@lists.sf.net, kernel-janitors@lists.osdl.org
Subject: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove
Date: Wed, 02 Feb 2005 23:16:29 +0000	[thread overview]
Message-ID: <1107386189.11944.21.camel@pegasus> (raw)
In-Reply-To: <20050202225855.GY2546@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi Nish,

> Please consider applying.
> 
> Description: Remove deprecated interruptible_sleep_on_timeout() function calls
> and replace with direct wait-queue usage. Some naming conflicts occurred, which
> I tried to resolve appropriately. Patch is compile-tested.

you introduce more code than you remove. Is our code a special case or
why don't exists a simple API function as replacement?

Regards

Marcel



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	bluez-devel@lists.sf.net, kernel-janitors@lists.osdl.org
Subject: [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage
Date: Thu, 03 Feb 2005 00:16:29 +0100	[thread overview]
Message-ID: <1107386189.11944.21.camel@pegasus> (raw)
In-Reply-To: <20050202225855.GY2546@us.ibm.com>

Hi Nish,

> Please consider applying.
> 
> Description: Remove deprecated interruptible_sleep_on_timeout() function calls
> and replace with direct wait-queue usage. Some naming conflicts occurred, which
> I tried to resolve appropriately. Patch is compile-tested.

you introduce more code than you remove. Is our code a special case or
why don't exists a simple API function as replacement?

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2005-02-02 23:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 22:58 [KJ] [PATCH 19/20] bluetooth/bluecard_cs: remove Nishanth Aravamudan
2005-02-02 23:16 ` Marcel Holtmann [this message]
2005-02-02 23:16   ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-03  0:25   ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Nishanth Aravamudan
2005-02-03  0:25     ` [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Nishanth Aravamudan
2005-02-05  0:11     ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-05  0:11       ` [Bluez-devel] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-06 22:19       ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Nish Aravamudan
2005-02-06 22:19         ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Nish Aravamudan
2005-02-06 22:38         ` [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Marcel Holtmann
2005-02-06 22:38           ` [Bluez-devel] Re: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
2005-02-18 23:43       ` [KJ] Re: bluetooth/bluecard_cs: remove Domen Puncer
2005-02-18 23:43         ` bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1107386189.11944.21.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sf.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=maxk@qualcomm.com \
    --cc=nacc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.