* [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup
@ 2005-02-14 22:02 Stephen Biggs
2005-02-14 22:15 ` [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning Dave Jones
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Biggs @ 2005-02-14 22:02 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 861 bytes --]
Description: compile warning cleanup - silence compiler warning for
unused function that is either actually used as a driver function in a
table or is truly unused
Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/net/ibmlana.c linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c
--- linux-2.6.11-rc3-mm2-original/drivers/net/ibmlana.c 2005-02-12 12:06:38.000000000 +0200
+++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200
@@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
static int startslot; /* counts through slots when probing multiple devices */
-static int ibmlana_probe(struct net_device *dev)
+static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
{
int slot, z;
int base = 0, irq = 0, iobase = 0, memlen = 0;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup Stephen Biggs
@ 2005-02-14 22:15 ` Dave Jones
2005-02-15 6:42 ` Stephen Biggs
2005-02-15 10:38 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jones @ 2005-02-14 22:15 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: compile warning cleanup - silence compiler warning for
> unused function that is either actually used as a driver function in a
> table or is truly unused
>
> +++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200
> @@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
>
> static int startslot; /* counts through slots when probing multiple devices */
>
> -static int ibmlana_probe(struct net_device *dev)
> +static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
It's called in init_module(). I guess you only tried this in the built-in case ?
Dave
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup Stephen Biggs
2005-02-14 22:15 ` [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning Dave Jones
@ 2005-02-15 6:42 ` Stephen Biggs
2005-02-15 10:38 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Biggs @ 2005-02-15 6:42 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 980 bytes --]
On 14 Feb 2005 at 17:15, Dave Jones wrote:
> On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
> Content-Description: Mail message body
> > Description: compile warning cleanup - silence compiler warning for
> > unused function that is either actually used as a driver function in a
> > table or is truly unused
> >
> > +++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200
> > @@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
> >
> > static int startslot; /* counts through slots when probing multiple devices */
> >
> > -static int ibmlana_probe(struct net_device *dev)
> > +static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
>
> It's called in init_module(). I guess you only tried this in the built-in case ?
It compiles both with allyesconfig and allmodconfig. The "unused"
attribute is a better solution than #ifdef MODULE.
Please consider applying.
>
> Dave
>
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup Stephen Biggs
2005-02-14 22:15 ` [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning Dave Jones
2005-02-15 6:42 ` Stephen Biggs
@ 2005-02-15 10:38 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2005-02-15 10:38 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Tue, Feb 15, 2005 at 08:42:55AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> On 14 Feb 2005 at 17:15, Dave Jones wrote:
>
> > On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
> > Content-Description: Mail message body
> > > Description: compile warning cleanup - silence compiler warning for
> > > unused function that is either actually used as a driver function in a
> > > table or is truly unused
> > >
> > > +++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200
> > > @@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
> > >
> > > static int startslot; /* counts through slots when probing multiple devices */
> > >
> > > -static int ibmlana_probe(struct net_device *dev)
> > > +static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
> >
> > It's called in init_module(). I guess you only tried this in the built-in case ?
>
> It compiles both with allyesconfig and allmodconfig. The "unused"
> attribute is a better solution than #ifdef MODULE.
It's not. It's a big mess.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-02-15 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup Stephen Biggs
2005-02-14 22:15 ` [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning Dave Jones
2005-02-15 6:42 ` Stephen Biggs
2005-02-15 10:38 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.