All of lore.kernel.org
 help / color / mirror / Atom feed
* framebuffer blanking
@ 2005-02-15 10:33 Meelis Roos
  2005-02-15 16:02 ` David S. Miller
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-15 10:33 UTC (permalink / raw)
  To: sparclinux

I have cg3 and cg6 framebuffers in my SS5. Current snapshot kernel makes 
both work well for fb console (haven't tried X). There is only one 
strange thing left - console blanking.

Both cg3 and cg6 behave the same: when it's blanking time, cursor is 
turned off but all the text stays. When I press a key to unblank, the 
cursor appears again and start flashing like usual.

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
@ 2005-02-15 16:02 ` David S. Miller
  2005-02-15 16:10 ` David S. Miller
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: David S. Miller @ 2005-02-15 16:02 UTC (permalink / raw)
  To: sparclinux

On Tue, 15 Feb 2005 12:33:15 +0200 (EET)
Meelis Roos <mroos@linux.ee> wrote:

> I have cg3 and cg6 framebuffers in my SS5. Current snapshot kernel makes 
> both work well for fb console (haven't tried X). There is only one 
> strange thing left - console blanking.
> 
> Both cg3 and cg6 behave the same: when it's blanking time, cursor is 
> turned off but all the text stays. When I press a key to unblank, the 
> cursor appears again and start flashing like usual.

Put some debugging printk()'s into drivers/video/cg3.c:cg3_blank() to
see if it's actually getting called and programming the registers.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
  2005-02-15 16:02 ` David S. Miller
@ 2005-02-15 16:10 ` David S. Miller
  2005-02-16  6:48 ` Meelis Roos
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: David S. Miller @ 2005-02-15 16:10 UTC (permalink / raw)
  To: sparclinux

On Tue, 15 Feb 2005 08:02:21 -0800
"David S. Miller" <davem@davemloft.net> wrote:

> On Tue, 15 Feb 2005 12:33:15 +0200 (EET)
> Meelis Roos <mroos@linux.ee> wrote:
> 
> > I have cg3 and cg6 framebuffers in my SS5. Current snapshot kernel makes 
> > both work well for fb console (haven't tried X). There is only one 
> > strange thing left - console blanking.
> > 
> > Both cg3 and cg6 behave the same: when it's blanking time, cursor is 
> > turned off but all the text stays. When I press a key to unblank, the 
> > cursor appears again and start flashing like usual.
> 
> Put some debugging printk()'s into drivers/video/cg3.c:cg3_blank() to
> see if it's actually getting called and programming the registers.

Actually I spotted the cg3 problem already.  You'll need to add some
debugging to the cg6 case as I can't find any problems with the blanking
code there.  If the cg6 is not the primary console, probably the blank
function simply isn't being invoked.

Anyways, here is the cg3 fix:

=== drivers/video/cg3.c 1.16 vs edited ==--- 1.16/drivers/video/cg3.c	2005-02-11 23:26:17 -08:00
+++ edited/drivers/video/cg3.c	2005-02-15 07:36:43 -08:00
@@ -209,7 +209,7 @@
 	case FB_BLANK_HSYNC_SUSPEND: /* VESA blank (hsync off) */
 	case FB_BLANK_POWERDOWN: /* Poweroff */
 		val = sbus_readb(&regs->control);
-		val |= CG3_CR_ENABLE_VIDEO;
+		val &= ~CG3_CR_ENABLE_VIDEO;
 		sbus_writeb(val, &regs->control);
 		par->flags |= CG3_FLAG_BLANKED;
 		break;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
  2005-02-15 16:02 ` David S. Miller
  2005-02-15 16:10 ` David S. Miller
@ 2005-02-16  6:48 ` Meelis Roos
  2005-02-16  7:34 ` Meelis Roos
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-16  6:48 UTC (permalink / raw)
  To: sparclinux

> Actually I spotted the cg3 problem already.  You'll need to add some
> debugging to the cg6 case as I can't find any problems with the blanking
> code there.  If the cg6 is not the primary console, probably the blank
> function simply isn't being invoked.
>
> Anyways, here is the cg3 fix:

Thanks, this indeed fixes cg3.

Will try to debug cg6 when I get some time.

-- 
Meelis Roos

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
                   ` (2 preceding siblings ...)
  2005-02-16  6:48 ` Meelis Roos
@ 2005-02-16  7:34 ` Meelis Roos
  2005-02-16 13:29 ` Meelis Roos
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-16  7:34 UTC (permalink / raw)
  To: sparclinux

> You'll need to add some
> debugging to the cg6 case as I can't find any problems with the blanking
> code there.  If the cg6 is not the primary console, probably the blank
> function simply isn't being invoked.

Tried it with some printks and cg6 as the primary console. These printks 
show that when blanking, cg6_blank is entered twice, first time it 
actually goes into the blanking case and the second time into 
unblanking.

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
                   ` (3 preceding siblings ...)
  2005-02-16  7:34 ` Meelis Roos
@ 2005-02-16 13:29 ` Meelis Roos
  2005-02-16 15:50 ` David S. Miller
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-16 13:29 UTC (permalink / raw)
  To: sparclinux

> Actually I spotted the cg3 problem already.  You'll need to add some
> debugging to the cg6 case as I can't find any problems with the blanking
> code there.  If the cg6 is not the primary console, probably the blank
> function simply isn't being invoked.

I redid my printks to be KERN_DEBUG and now unblanking does not happen, 
only one call to cg6_blank and this does the blanking case. But only 
cursor disappears.

-- 
Meelis Roos

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
                   ` (4 preceding siblings ...)
  2005-02-16 13:29 ` Meelis Roos
@ 2005-02-16 15:50 ` David S. Miller
  2005-02-16 16:03 ` Meelis Roos
  2005-02-16 17:14 ` Meelis Roos
  7 siblings, 0 replies; 9+ messages in thread
From: David S. Miller @ 2005-02-16 15:50 UTC (permalink / raw)
  To: sparclinux

On Wed, 16 Feb 2005 15:29:16 +0200 (EET)
Meelis Roos <mroos@linux.ee> wrote:

> > Actually I spotted the cg3 problem already.  You'll need to add some
> > debugging to the cg6 case as I can't find any problems with the blanking
> > code there.  If the cg6 is not the primary console, probably the blank
> > function simply isn't being invoked.
> 
> I redid my printks to be KERN_DEBUG and now unblanking does not happen, 
> only one call to cg6_blank and this does the blanking case. But only 
> cursor disappears.

Right, I bet your debugging printk()'s prompted the console to unblank :-)
Could you quickly confirm that 2.4.x does blank properly on cg6 for you?
I believe you said this already, but I want to make sure.

Thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
                   ` (5 preceding siblings ...)
  2005-02-16 15:50 ` David S. Miller
@ 2005-02-16 16:03 ` Meelis Roos
  2005-02-16 17:14 ` Meelis Roos
  7 siblings, 0 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-16 16:03 UTC (permalink / raw)
  To: sparclinux

> Right, I bet your debugging printk()'s prompted the console to unblank :-)

Yes, that's what I thought too.

> Could you quickly confirm that 2.4.x does blank properly on cg6 for you?
> I believe you said this already, but I want to make sure.

No, I didn't test 2.4 yet, will do.

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: framebuffer blanking
  2005-02-15 10:33 framebuffer blanking Meelis Roos
                   ` (6 preceding siblings ...)
  2005-02-16 16:03 ` Meelis Roos
@ 2005-02-16 17:14 ` Meelis Roos
  7 siblings, 0 replies; 9+ messages in thread
From: Meelis Roos @ 2005-02-16 17:14 UTC (permalink / raw)
  To: sparclinux

> Could you quickly confirm that 2.4.x does blank properly on cg6 for you?

Yes, 2.4.30-pre1 blanks and unblanks correctly.

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2005-02-16 17:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-15 10:33 framebuffer blanking Meelis Roos
2005-02-15 16:02 ` David S. Miller
2005-02-15 16:10 ` David S. Miller
2005-02-16  6:48 ` Meelis Roos
2005-02-16  7:34 ` Meelis Roos
2005-02-16 13:29 ` Meelis Roos
2005-02-16 15:50 ` David S. Miller
2005-02-16 16:03 ` Meelis Roos
2005-02-16 17:14 ` Meelis Roos

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.