Re: x86 serial support

["Yoshinori K. Okuji" <okuji@enbug.org>]

Sorry, I forgot to send a reply.

On Monday 21 February 2005 13:38, Omniflux wrote:
> Here is a patch to add serial support to x86.

Great.

> If this is headed in the right direction, and likely to be accepted
> for merging with a little more work, I'll keep working on it.

I think this is a good way. But some problems must be solved:

- Naming issues. Since you copied the code from GRUB Legacy, some names 
are not appropriate in GRUB 2. For example, the global function 
declared in terminfo.h do not use the prefix 'grub_' at all.

- Module separation. I think it would be better to have a separate 
module for terminfo, because we might be able to use it for other 
terminals as well as serial console, say, parallel console.

- ChangeLog. Please write ChangeLog entries for your changes.

BTW, do you have any suggestion about the so-called "dumb terminal"? 
Because supporting dumb terminal is horrible, I hesitate to support it 
in GRUB 2, if there is no clean way to do it.

Okuji