From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: x86 serial support
Date: Sat, 3 Sep 2005 19:08:30 +0200 [thread overview]
Message-ID: <200509031908.30915.okuji@enbug.org> (raw)
In-Reply-To: <42F94D30.7030204@omniflux.com>
On Wednesday 10 August 2005 02:41, Omniflux wrote:
> It's been a few months, but here are some updated patches.
I've checked in your patch with some modification right now. I changed these
below:
- I removed EXPORT_FUNC from terminfo.h. EXPORT_FUNC is required only if you
want to export symbols from the kernel.
- I moved the inline functions in serial.h to serial.c, because they are not
used outside.
- I fixed bad indentation.
- I removed odd const qualifiers to integers.
- I fixed a memory leak in the serial command.
I might have changed some other minor things as well.
For now, terminfo.c has code of interpreting terminfo, but supports only
vt100. Do you intend to fix this?
Okuji
next prev parent reply other threads:[~2005-09-03 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-21 12:38 x86 serial support Omniflux
2005-03-02 21:33 ` Yoshinori K. Okuji
2005-08-10 0:41 ` Omniflux
2005-08-12 10:51 ` Vladimir Serbinenko
2005-08-12 16:01 ` Marco Gerards
2005-08-12 20:17 ` Yoshinori K. Okuji
2005-08-12 22:19 ` Douglas Wade Needham
2005-08-12 22:18 ` Omniflux
2005-08-14 13:03 ` Marco Gerards
2005-08-14 14:54 ` Yoshinori K. Okuji
2005-09-03 17:08 ` Yoshinori K. Okuji [this message]
2005-09-03 23:12 ` Marco Gerards
2005-09-11 19:46 ` Yoshinori K. Okuji
2005-09-04 0:59 ` Omniflux
2005-09-11 19:52 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509031908.30915.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.