All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: adaplas@pol.net
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: RFC: disallow modular framebuffers
Date: Thu, 3 Mar 2005 21:20:39 +0100	[thread overview]
Message-ID: <20050303202039.GH4608@stusta.de> (raw)
In-Reply-To: <200503040350.51163.adaplas@hotpop.com>

On Fri, Mar 04, 2005 at 03:50:42AM +0800, Antonino A. Daplas wrote:
>...
> > Is there any reason for these being three modules?
> > It seems the best solution would be to make this one module composed of
> > up to three object files?
> 
> Yes.

Two possible solutions:
- rename savagefb.c and link the three files into savagefb.o
- merge the other two files into savagefb.c

I'd slightly prefer the first choice, but I can send patches for 
whichever you prefer.

As a note, in both cases the EXPORT_SYMBOL's can be removed.

> Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: adaplas@pol.net
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: RFC: disallow modular framebuffers
Date: Thu, 3 Mar 2005 21:20:39 +0100	[thread overview]
Message-ID: <20050303202039.GH4608@stusta.de> (raw)
In-Reply-To: <200503040350.51163.adaplas@hotpop.com>

On Fri, Mar 04, 2005 at 03:50:42AM +0800, Antonino A. Daplas wrote:
>...
> > Is there any reason for these being three modules?
> > It seems the best solution would be to make this one module composed of
> > up to three object files?
> 
> Yes.

Two possible solutions:
- rename savagefb.c and link the three files into savagefb.o
- merge the other two files into savagefb.c

I'd slightly prefer the first choice, but I can send patches for 
whichever you prefer.

As a note, in both cases the EXPORT_SYMBOL's can be removed.

> Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-03-03 20:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-01  2:41 RFC: disallow modular framebuffers Adrian Bunk
2005-03-01  3:46 ` Jeff Garzik
2005-03-01  6:07   ` Jon Smirl
2005-03-01  6:07     ` Jon Smirl
2005-03-01 17:52     ` [Linux-fbdev-devel] " James Simmons
2005-03-01 12:49 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 12:49   ` Antonino A. Daplas
2005-03-01 13:15 ` Antonino A. Daplas
2005-03-03 16:56   ` Adrian Bunk
2005-03-03 19:50     ` Antonino A. Daplas
2005-03-03 20:20       ` Adrian Bunk [this message]
2005-03-03 20:20         ` Adrian Bunk
2005-03-03 20:37         ` Antonino A. Daplas
2005-03-03 20:37           ` Antonino A. Daplas
2005-03-03 23:07           ` [2.6 patch] make savagefb one module Adrian Bunk
2005-03-04  9:17             ` [Linux-fbdev-devel] " Geert Uytterhoeven
2005-03-05  1:12               ` Adrian Bunk
2005-03-05  1:12                 ` [Linux-fbdev-devel] " Adrian Bunk
2005-03-05 20:49                 ` Antonino A. Daplas
2005-03-05 20:49                   ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 16:59 ` RFC: disallow modular framebuffers Jesse Barnes
2005-03-02 11:32 ` [Linux-fbdev-devel] " David Vrabel
2005-03-02 12:17 ` Paul Mundt
2005-03-02 18:01   ` Jon Smirl
2005-03-02 18:01     ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050303202039.GH4608@stusta.de \
    --to=bunk@stusta.de \
    --cc=adaplas@pol.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.