From: Ralf Baechle <ralf@linux-mips.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-arch@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH] consolidate shmat usage
Date: Tue, 5 Apr 2005 21:00:55 +0100 [thread overview]
Message-ID: <20050405200055.GO16601@linux-mips.org> (raw)
In-Reply-To: <20050405130312.GC16157@parcelfarce.linux.theplanet.co.uk>
On Tue, Apr 05, 2005 at 02:03:12PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 05, 2005 at 06:01:32PM +1000, Stephen Rothwell wrote:
> > On Wed, 23 Mar 2005 14:51:32 +0000 Matthew Wilcox <matthew@wil.cx> wrote:
> > > I dislike the naming here. The manpage for shmat is the three-argument
> > > version. The only reason we have the four-argument version is because
> > > of the silly sys_ipc multiplexer. So I think sys_shmat() should be
> > > the three-argument form and we should rename the existing sys_shmat()
> > > to something like ipc_shmat(). Does it need to be asmlinkage?
> >
> > OK, I have changed sys_shmat to sys_shmat4 and sys_shmatcall to sys_shmat.
> > There are some architectures that use each of these directly as system
> > calls.
>
> Umm. I think you've just discovered a bug in ARM and MIPS. I don't see
> any code in glibc for handling the 4-argument version of sys_shmat.
> Russell, Ralf, could you comment?
On MIPS it affects only 64-bit systems running native code which few people
do. Fixing it as I'm writing this,
Ralf
next prev parent reply other threads:[~2005-04-05 20:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 4:01 [PATCH] consolidate asm/ipc.h Stephen Rothwell
2005-03-23 4:12 ` David S. Miller
2005-03-23 6:48 ` [PATCH] consolidate shmat usage Stephen Rothwell
2005-03-23 10:54 ` David Howells
2005-04-05 8:02 ` Stephen Rothwell
2005-03-23 14:51 ` Matthew Wilcox
2005-04-05 8:01 ` Stephen Rothwell
2005-04-05 13:03 ` Matthew Wilcox
2005-04-05 20:00 ` Ralf Baechle [this message]
2005-04-05 20:16 ` Russell King
2005-04-05 20:20 ` Ralf Baechle
2005-04-06 15:05 ` Stephen Rothwell
2005-04-07 5:14 ` Stephen Rothwell
2005-04-11 20:29 ` Russell King
2005-04-27 6:27 ` [PATCH] consolidate sys_shmat Stephen Rothwell
2005-04-27 12:50 ` Ralf Baechle
2005-04-27 14:36 ` Stephen Rothwell
2005-04-05 8:05 ` [PATCH] consolidate shmat usage Stephen Rothwell
2005-03-23 8:06 ` [PATCH] consolidate asm/ipc.h Andi Kleen
2005-03-24 0:30 ` Stephen Rothwell
2005-03-23 10:49 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405200055.GO16601@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-arch@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rmk@arm.linux.org.uk \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.