From: Tobias Klauser <tklauser@nuerscht.ch>
To: kernel-janitors@lists.osdl.org
Cc: linux-scsi@vger.kernel.org
Subject: [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and
Date: Wed, 13 Apr 2005 12:11:20 +0000 [thread overview]
Message-ID: <20050413121104.GA9419@argon.tklauser.home> (raw)
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
Replace the MS_TO_JIFFIES() macro with msecs_to_jiffies() from jiffies.h
The current macro is incorrect because HZ can have different values on
different architectures.
The patch also removes the JIFFIES_TO_MS() macro which is not used
anymore in the code.
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
diff -urpN linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c
--- linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c 2005-03-02 08:38:12.000000000 +0100
+++ linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c 2005-04-13 13:53:19.000000000 +0200
@@ -100,10 +100,6 @@
#include "a100u2w.h"
-
-#define JIFFIES_TO_MS(t) ((t) * 1000 / HZ)
-#define MS_TO_JIFFIES(j) ((j * HZ) / 1000)
-
static ORC_SCB *orc_alloc_scb(ORC_HCS * hcsp);
static void inia100SCBPost(BYTE * pHcb, BYTE * pScb);
@@ -160,7 +156,7 @@ static UCHAR dftNvRam[64] =
/***************************************************************************/
static void waitForPause(unsigned amount)
{
- ULONG the_time = jiffies + MS_TO_JIFFIES(amount);
+ ULONG the_time = jiffies + msecs_to_jiffies(amount);
while (time_before_eq(jiffies, the_time))
cpu_relax();
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Tobias Klauser <tklauser@nuerscht.ch>
To: kernel-janitors@lists.osdl.org
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros
Date: Wed, 13 Apr 2005 14:11:20 +0200 [thread overview]
Message-ID: <20050413121104.GA9419@argon.tklauser.home> (raw)
Replace the MS_TO_JIFFIES() macro with msecs_to_jiffies() from jiffies.h
The current macro is incorrect because HZ can have different values on
different architectures.
The patch also removes the JIFFIES_TO_MS() macro which is not used
anymore in the code.
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
diff -urpN linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c
--- linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c 2005-03-02 08:38:12.000000000 +0100
+++ linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c 2005-04-13 13:53:19.000000000 +0200
@@ -100,10 +100,6 @@
#include "a100u2w.h"
-
-#define JIFFIES_TO_MS(t) ((t) * 1000 / HZ)
-#define MS_TO_JIFFIES(j) ((j * HZ) / 1000)
-
static ORC_SCB *orc_alloc_scb(ORC_HCS * hcsp);
static void inia100SCBPost(BYTE * pHcb, BYTE * pScb);
@@ -160,7 +156,7 @@ static UCHAR dftNvRam[64] =
/***************************************************************************/
static void waitForPause(unsigned amount)
{
- ULONG the_time = jiffies + MS_TO_JIFFIES(amount);
+ ULONG the_time = jiffies + msecs_to_jiffies(amount);
while (time_before_eq(jiffies, the_time))
cpu_relax();
}
next reply other threads:[~2005-04-13 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 12:11 Tobias Klauser [this message]
2005-04-13 12:11 ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Tobias Klauser
2005-04-13 13:29 ` [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Alexey Dobriyan
2005-04-13 17:28 ` [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Alexey Dobriyan
2005-04-13 14:43 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Christoph Hellwig
2005-04-13 14:43 ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Christoph Hellwig
2005-04-13 14:51 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Christoph Hellwig
2005-04-13 14:51 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Christoph Hellwig
2005-04-13 15:00 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and James Bottomley
2005-04-13 15:00 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros James Bottomley
2005-04-13 15:01 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Tobias Klauser
2005-04-13 15:01 ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413121104.GA9419@argon.tklauser.home \
--to=tklauser@nuerscht.ch \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.