All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@mail.ru>
To: Tobias Klauser <tklauser@nuerscht.ch>
Cc: kernel-janitors@lists.osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and
Date: Wed, 13 Apr 2005 13:29:53 +0000	[thread overview]
Message-ID: <200504131728.46401.adobriyan@mail.ru> (raw)
In-Reply-To: <20050413121104.GA9419@argon.tklauser.home>

On Wednesday 13 April 2005 12:11, Tobias Klauser wrote:
> Replace the MS_TO_JIFFIES() macro with msecs_to_jiffies() from jiffies.h

> --- linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c
> +++ linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c

>  static void waitForPause(unsigned amount)
>  {
> -	ULONG the_time = jiffies + MS_TO_JIFFIES(amount);
> +	ULONG the_time = jiffies + msecs_to_jiffies(amount);
>  	while (time_before_eq(jiffies, the_time))
>  		cpu_relax();
>  }

It'd be better to find out what is the equivalent generic sleeping/delaying
function and, if any, remove waitForPause() altogether.

However, Bas Vermeulen added these lines at the top of the file:

	* 01/31/99 bv - v1.02b Use mdelay instead of waitForPause
	* 08/08/99 bv - v1.02c Use waitForPause again.

Maybe he can recall what was wrong with mdelay().
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Dobriyan <adobriyan@mail.ru>
To: Tobias Klauser <tklauser@nuerscht.ch>
Cc: kernel-janitors@lists.osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros
Date: Wed, 13 Apr 2005 17:28:46 +0000	[thread overview]
Message-ID: <200504131728.46401.adobriyan@mail.ru> (raw)
In-Reply-To: <20050413121104.GA9419@argon.tklauser.home>

On Wednesday 13 April 2005 12:11, Tobias Klauser wrote:
> Replace the MS_TO_JIFFIES() macro with msecs_to_jiffies() from jiffies.h

> --- linux-2.6.12-rc2-mm3/drivers/scsi/a100u2w.c
> +++ linux-2.6.12-rc2-mm3-tk/drivers/scsi/a100u2w.c

>  static void waitForPause(unsigned amount)
>  {
> -	ULONG the_time = jiffies + MS_TO_JIFFIES(amount);
> +	ULONG the_time = jiffies + msecs_to_jiffies(amount);
>  	while (time_before_eq(jiffies, the_time))
>  		cpu_relax();
>  }

It'd be better to find out what is the equivalent generic sleeping/delaying
function and, if any, remove waitForPause() altogether.

However, Bas Vermeulen added these lines at the top of the file:

	* 01/31/99 bv - v1.02b Use mdelay instead of waitForPause
	* 08/08/99 bv - v1.02c Use waitForPause again.

Maybe he can recall what was wrong with mdelay().

  reply	other threads:[~2005-04-13 13:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-13 12:11 [KJ] [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Tobias Klauser
2005-04-13 12:11 ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Tobias Klauser
2005-04-13 13:29 ` Alexey Dobriyan [this message]
2005-04-13 17:28   ` [KJ] " Alexey Dobriyan
2005-04-13 14:43 ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Christoph Hellwig
2005-04-13 14:43   ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Christoph Hellwig
2005-04-13 14:51   ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Christoph Hellwig
2005-04-13 14:51     ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Christoph Hellwig
2005-04-13 15:00     ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and James Bottomley
2005-04-13 15:00       ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros James Bottomley
2005-04-13 15:01     ` [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and Tobias Klauser
2005-04-13 15:01       ` [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504131728.46401.adobriyan@mail.ru \
    --to=adobriyan@mail.ru \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=tklauser@nuerscht.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.