From: dtor_core@ameritech.net (Dmitry Torokhov)
To: linux-kernel@vger.kernel.org
Cc: Greg KH <gregkh@suse.de>,
khali@linux-fr.org, sensors@stimpy.netroedge.com,
stable@kernel.org, Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Cliff White <cliffw@osdl.org>, Theodore Ts'o <tytso@mit.edu>,
"Randy.Dunlap" <rddunlap@osdl.org>,
Chuck Wolber <chuckw@quantumlinux.com>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and
Date: Thu, 19 May 2005 06:25:55 +0000 [thread overview]
Message-ID: <200504280047.43130.dtor_core@ameritech.net> (raw)
In-Reply-To: <20050427171617.GD3195@kroah.com>
On Wednesday 27 April 2005 12:16, Greg KH wrote:
> As a side note, wouldn't it make sense to check, when creating sysfs
> files, that readable files have a non-NULL show method, and writable
> files have a non-NULL store method? I know drivers are not supposed to
> do stupid things, but there is already a BUG_ON for several conditions
> in sysfs_create_file, so maybe we could add two more?
Checking at creation time is not enough. Even with such check one could
change permissions on a sysfs file and set write bit.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Greg KH <gregkh@suse.de>,
khali@linux-fr.org, sensors@stimpy.netroedge.com,
stable@kernel.org, Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Cliff White <cliffw@osdl.org>, "Theodore Ts'o" <tytso@mit.edu>,
"Randy.Dunlap" <rddunlap@osdl.org>,
Chuck Wolber <chuckw@quantumlinux.com>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers
Date: Thu, 28 Apr 2005 00:47:42 -0500 [thread overview]
Message-ID: <200504280047.43130.dtor_core@ameritech.net> (raw)
In-Reply-To: <20050427171617.GD3195@kroah.com>
On Wednesday 27 April 2005 12:16, Greg KH wrote:
> As a side note, wouldn't it make sense to check, when creating sysfs
> files, that readable files have a non-NULL show method, and writable
> files have a non-NULL store method? I know drivers are not supposed to
> do stupid things, but there is already a BUG_ON for several conditions
> in sysfs_create_file, so maybe we could add two more?
Checking at creation time is not enough. Even with such check one could
change permissions on a sysfs file and set write bit.
--
Dmitry
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 17:14 [00/07] -stable review Greg KH
2005-04-27 17:15 ` [uml-devel] [01/07] uml: add nfsd syscall when nfsd is modular Greg KH
2005-04-27 17:15 ` Greg KH
2005-04-27 16:33 ` [uml-devel] " Alan Cox
2005-04-27 16:33 ` Alan Cox
2005-04-27 17:46 ` [uml-devel] " Chris Wright
2005-04-27 17:46 ` Chris Wright
2005-04-27 17:23 ` [uml-devel] " Alan Cox
2005-04-27 17:23 ` Alan Cox
2005-04-27 18:47 ` [uml-devel] " Chris Wright
2005-04-27 18:47 ` Chris Wright
2005-04-29 4:16 ` [uml-devel] " Greg KH
2005-04-29 4:16 ` Greg KH
2005-04-27 17:16 ` [02/07] [fix Bug 4395] modprobe bttv freezes the computer Greg KH
2005-04-27 17:16 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Greg KH
2005-05-19 6:25 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a Greg KH
2005-04-27 19:41 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Dmitry Torokhov
2005-05-19 6:25 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and Dmitry Torokhov
2005-04-27 19:49 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Dmitry Torokhov
2005-05-19 6:25 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and Dmitry Torokhov
2005-04-28 5:47 ` Dmitry Torokhov [this message]
2005-05-19 6:25 ` Dmitry Torokhov
2005-04-27 17:16 ` [04/07] partitions/msdos.c fix Greg KH
2005-04-27 20:34 ` Andries Brouwer
2005-04-27 20:49 ` Erik Tews
2005-04-27 22:08 ` Andries Brouwer
2005-04-27 20:35 ` Pavel Machek
2005-04-27 17:16 ` [05/07] [PATCH] Fix reproducible SMP crash in security/keys/key.c Greg KH
2005-04-27 17:16 ` [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc Greg KH
2005-04-27 16:38 ` Alan Cox
2005-04-27 18:26 ` Greg KH
2005-04-27 17:51 ` Alan Cox
2005-04-28 5:43 ` Kai Makisara
2005-04-28 12:49 ` Arjan van de Ven
2005-04-28 13:21 ` Alan Cox
2005-04-29 4:20 ` Greg KH
2005-04-29 20:16 ` Alan Cox
2005-04-29 20:38 ` Greg KH
2005-04-30 5:52 ` Kai Makisara
2005-04-30 5:10 ` Greg KH
2005-04-30 8:10 ` Kai Makisara
2005-04-27 17:17 ` [uml-devel] [07/07] uml: quick fix syscall table Greg KH
2005-04-27 17:17 ` Greg KH
2005-04-27 18:26 ` [00/07] -stable review Chris Wright
2005-04-27 18:31 ` [08/07] sparc64: Fix copy_siginfo_to_user32() Chris Wright
2005-04-27 18:35 ` [09/07] sparc64: use message queue compat syscalls Chris Wright
2005-04-27 18:38 ` [10/07] sparc: Fix PTRACE_CONT bogosity Chris Wright
2005-04-27 17:53 ` Alan Cox
2005-04-28 0:13 ` [00/07] -stable review Nick Piggin
2005-04-28 1:33 ` Chris Wright
2005-04-28 1:43 ` Nick Piggin
2005-04-29 4:14 ` Rules about the -stable tree Greg KH
2005-04-28 1:51 ` [00/07] -stable review Zwane Mwaikambo
2005-04-28 1:51 ` Nick Piggin
2005-04-28 1:54 ` Justin M. Forbes
2005-04-28 6:49 ` Gregor Jasny
2005-04-28 6:59 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504280047.43130.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chuckw@quantumlinux.com \
--cc=cliffw@osdl.org \
--cc=gregkh@suse.de \
--cc=jmforbes@linuxtx.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=sensors@stimpy.netroedge.com \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.