All of lore.kernel.org
 help / color / mirror / Atom feed
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: Greg KH <gregkh@suse.de>
Cc: khali@linux-fr.org, sensors@stimpy.netroedge.com,
	linux-kernel@vger.kernel.org, stable@kernel.org,
	Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Cliff White <cliffw@osdl.org>, Theodore Ts'o <tytso@mit.edu>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and
Date: Thu, 19 May 2005 06:25:55 +0000	[thread overview]
Message-ID: <d120d50005042712417656ba3a@mail.gmail.com> (raw)
In-Reply-To: <20050427171617.GD3195@kroah.com>

On 4/27/05, Greg KH <gregkh@suse.de> wrote:
> 
> -stable review patch.  If anyone has any objections, please let us know.
> 

While the patch is correct I'd have something like this as well:

--- linux-2.6.11.orig/fs/sysfs/file.c
+++ linux-2.6.11/fs/sysfs/file.c
@@ -36,7 +36,7 @@ subsys_attr_store(struct kobject * kobj,
 {
        struct subsystem * s = to_subsys(kobj);
        struct subsys_attribute * sattr = to_sattr(attr);
-       ssize_t ret = 0;
+       ssize_t ret = -ENOSYS;
 
        if (sattr->store)
                ret = sattr->store(s,page,count);

So writes without store handler would return "not implemented".

(It is whitespace-mangled and therefore not a real patch - so no
signed-off-by...)

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: khali@linux-fr.org, sensors@stimpy.netroedge.com,
	linux-kernel@vger.kernel.org, stable@kernel.org,
	Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Cliff White <cliffw@osdl.org>, "Theodore Ts'o" <tytso@mit.edu>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers
Date: Wed, 27 Apr 2005 14:41:56 -0500	[thread overview]
Message-ID: <d120d50005042712417656ba3a@mail.gmail.com> (raw)
In-Reply-To: <20050427171617.GD3195@kroah.com>

On 4/27/05, Greg KH <gregkh@suse.de> wrote:
> 
> -stable review patch.  If anyone has any objections, please let us know.
> 

While the patch is correct I'd have something like this as well:

--- linux-2.6.11.orig/fs/sysfs/file.c
+++ linux-2.6.11/fs/sysfs/file.c
@@ -36,7 +36,7 @@ subsys_attr_store(struct kobject * kobj,
 {
        struct subsystem * s = to_subsys(kobj);
        struct subsys_attribute * sattr = to_sattr(attr);
-       ssize_t ret = 0;
+       ssize_t ret = -ENOSYS;
 
        if (sattr->store)
                ret = sattr->store(s,page,count);

So writes without store handler would return "not implemented".

(It is whitespace-mangled and therefore not a real patch - so no
signed-off-by...)

-- 
Dmitry

  reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-27 17:14 [00/07] -stable review Greg KH
2005-04-27 17:15 ` [uml-devel] [01/07] uml: add nfsd syscall when nfsd is modular Greg KH
2005-04-27 17:15   ` Greg KH
2005-04-27 16:33   ` [uml-devel] " Alan Cox
2005-04-27 16:33     ` Alan Cox
2005-04-27 17:46     ` [uml-devel] " Chris Wright
2005-04-27 17:46       ` Chris Wright
2005-04-27 17:23       ` [uml-devel] " Alan Cox
2005-04-27 17:23         ` Alan Cox
2005-04-27 18:47         ` [uml-devel] " Chris Wright
2005-04-27 18:47           ` Chris Wright
2005-04-29  4:16           ` [uml-devel] " Greg KH
2005-04-29  4:16             ` Greg KH
2005-04-27 17:16 ` [02/07] [fix Bug 4395] modprobe bttv freezes the computer Greg KH
2005-04-27 17:16 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Greg KH
2005-05-19  6:25   ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a Greg KH
2005-04-27 19:41   ` Dmitry Torokhov [this message]
2005-05-19  6:25     ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and Dmitry Torokhov
2005-04-27 19:49     ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Dmitry Torokhov
2005-05-19  6:25       ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and Dmitry Torokhov
2005-04-28  5:47   ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Dmitry Torokhov
2005-05-19  6:25     ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and Dmitry Torokhov
2005-04-27 17:16 ` [04/07] partitions/msdos.c fix Greg KH
2005-04-27 20:34   ` Andries Brouwer
2005-04-27 20:49     ` Erik Tews
2005-04-27 22:08       ` Andries Brouwer
2005-04-27 20:35   ` Pavel Machek
2005-04-27 17:16 ` [05/07] [PATCH] Fix reproducible SMP crash in security/keys/key.c Greg KH
2005-04-27 17:16 ` [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc Greg KH
2005-04-27 16:38   ` Alan Cox
2005-04-27 18:26     ` Greg KH
2005-04-27 17:51       ` Alan Cox
2005-04-28  5:43     ` Kai Makisara
2005-04-28 12:49       ` Arjan van de Ven
2005-04-28 13:21       ` Alan Cox
2005-04-29  4:20         ` Greg KH
2005-04-29 20:16           ` Alan Cox
2005-04-29 20:38             ` Greg KH
2005-04-30  5:52               ` Kai Makisara
2005-04-30  5:10                 ` Greg KH
2005-04-30  8:10                   ` Kai Makisara
2005-04-27 17:17 ` [uml-devel] [07/07] uml: quick fix syscall table Greg KH
2005-04-27 17:17   ` Greg KH
2005-04-27 18:26 ` [00/07] -stable review Chris Wright
2005-04-27 18:31 ` [08/07] sparc64: Fix copy_siginfo_to_user32() Chris Wright
2005-04-27 18:35 ` [09/07] sparc64: use message queue compat syscalls Chris Wright
2005-04-27 18:38 ` [10/07] sparc: Fix PTRACE_CONT bogosity Chris Wright
2005-04-27 17:53   ` Alan Cox
2005-04-28  0:13 ` [00/07] -stable review Nick Piggin
2005-04-28  1:33   ` Chris Wright
2005-04-28  1:43     ` Nick Piggin
2005-04-29  4:14       ` Rules about the -stable tree Greg KH
2005-04-28  1:51     ` [00/07] -stable review Zwane Mwaikambo
2005-04-28  1:51       ` Nick Piggin
2005-04-28  1:54       ` Justin M. Forbes
2005-04-28  6:49 ` Gregor Jasny
2005-04-28  6:59   ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d50005042712417656ba3a@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chuckw@quantumlinux.com \
    --cc=cliffw@osdl.org \
    --cc=gregkh@suse.de \
    --cc=jmforbes@linuxtx.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    --cc=sensors@stimpy.netroedge.com \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.