From: Nishanth Aravamudan <nacc@us.ibm.com>
To: loz@holmes.demon.co.uk, waltje@uwalt.nl.mugnet.org
Cc: netdev@oss.sgi.com, Kernel-Janitors <kernel-janitors@lists.osdl.org>
Subject: [KJ] [PATCH] net/slip: replace schedule_timeout() with
Date: Mon, 02 May 2005 06:34:57 +0000 [thread overview]
Message-ID: <20050502063457.GG10173@us.ibm.com> (raw)
In-Reply-To: <20050502061446.GB10173@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Use msleep_interruptible() instead of schedule_timeout() to guarantee
the task delays as expected.
--- 2.6.12-rc3/drivers/net/slip.c 2005-03-01 23:38:33.000000000 -0800
+++ 2.6.12-rc3-dev/drivers/net/slip.c 2005-05-01 20:53:08.000000000 -0700
@@ -1395,10 +1395,8 @@ static void __exit slip_exit(void)
/* First of all: check for active disciplines and hangup them.
*/
do {
- if (busy) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ / 10);
- }
+ if (busy)
+ msleep_interruptible(100);
busy = 0;
for (i = 0; i < slip_maxdev; i++) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: loz@holmes.demon.co.uk, waltje@uwalt.nl.mugnet.org
Cc: netdev@oss.sgi.com, Kernel-Janitors <kernel-janitors@lists.osdl.org>
Subject: [KJ] [PATCH] net/slip: replace schedule_timeout() with msleep_interruptible()
Date: Sun, 1 May 2005 23:34:57 -0700 [thread overview]
Message-ID: <20050502063457.GG10173@us.ibm.com> (raw)
In-Reply-To: <20050502061446.GB10173@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Use msleep_interruptible() instead of schedule_timeout() to guarantee
the task delays as expected.
--- 2.6.12-rc3/drivers/net/slip.c 2005-03-01 23:38:33.000000000 -0800
+++ 2.6.12-rc3-dev/drivers/net/slip.c 2005-05-01 20:53:08.000000000 -0700
@@ -1395,10 +1395,8 @@ static void __exit slip_exit(void)
/* First of all: check for active disciplines and hangup them.
*/
do {
- if (busy) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ / 10);
- }
+ if (busy)
+ msleep_interruptible(100);
busy = 0;
for (i = 0; i < slip_maxdev; i++) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-05-02 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-02 6:14 [KJ] [PATCH] net/3c505: replace schedule_timeout() with msleep() Nishanth Aravamudan
2005-05-02 6:14 ` Nishanth Aravamudan
2005-05-02 6:26 ` [KJ] [PATCH] ppc/fcc_enet: replace schedule_timeout() with ssleep() Nishanth Aravamudan
2005-05-02 6:26 ` Nishanth Aravamudan
2005-05-02 6:34 ` Nishanth Aravamudan [this message]
2005-05-02 6:34 ` [KJ] [PATCH] net/slip: replace schedule_timeout() with msleep_interruptible() Nishanth Aravamudan
-- strict thread matches above, loose matches on Subject: below --
2005-05-02 6:18 [KJ] [PATCH] i386/apm: use wait_event_interruptible_timeout() Nishanth Aravamudan
2005-05-02 6:18 ` Nishanth Aravamudan
2005-05-03 21:40 ` [KJ] " Nishanth Aravamudan
2005-05-03 21:40 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050502063457.GG10173@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=loz@holmes.demon.co.uk \
--cc=netdev@oss.sgi.com \
--cc=waltje@uwalt.nl.mugnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.