All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: dmalek@jlc.net
Cc: Kernel-Janitors <kernel-janitors@lists.osdl.org>,
	linuxppc-embedded@ozlabs.org
Subject: [KJ] [PATCH] ppc/fcc_enet: replace schedule_timeout() with ssleep()
Date: Mon, 02 May 2005 06:26:00 +0000	[thread overview]
Message-ID: <20050502062600.GD10173@us.ibm.com> (raw)
In-Reply-To: <20050502061446.GB10173@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

I couldn't find an appropriate entry in MAINTAINERS for this patch.

Use ssleep() instead of schedule_timeout() to guarantee the task delays
as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.12-rc3/arch/ppc/8260_io/fcc_enet.c	2005-04-29 11:03:03.000000000 -0700
+++ 2.6.12-rc3-dev/arch/ppc/8260_io/fcc_enet.c	2005-05-01 19:10:58.000000000 -0700
@@ -1305,12 +1305,11 @@ static void mii_parse_dm9161_scsr(uint m
 
 static void mii_dm9161_wait(uint mii_reg, struct net_device *dev)
 {
-	int timeout = HZ;
+	int timeout_secs = 1;
 
 	/* Davicom takes a bit to come up after a reset,
 	 * so wait here for a bit */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(timeout);
+	ssleep(timeout_secs);
 }
 
 static phy_info_t phy_info_dm9161 = {

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: dmalek@jlc.net
Cc: Kernel-Janitors <kernel-janitors@lists.osdl.org>,
	linuxppc-embedded@ozlabs.org
Subject: [PATCH] ppc/fcc_enet: replace schedule_timeout() with ssleep()
Date: Sun, 1 May 2005 23:26:00 -0700	[thread overview]
Message-ID: <20050502062600.GD10173@us.ibm.com> (raw)
In-Reply-To: <20050502061446.GB10173@us.ibm.com>

I couldn't find an appropriate entry in MAINTAINERS for this patch.

Use ssleep() instead of schedule_timeout() to guarantee the task delays
as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.12-rc3/arch/ppc/8260_io/fcc_enet.c	2005-04-29 11:03:03.000000000 -0700
+++ 2.6.12-rc3-dev/arch/ppc/8260_io/fcc_enet.c	2005-05-01 19:10:58.000000000 -0700
@@ -1305,12 +1305,11 @@ static void mii_parse_dm9161_scsr(uint m
 
 static void mii_dm9161_wait(uint mii_reg, struct net_device *dev)
 {
-	int timeout = HZ;
+	int timeout_secs = 1;
 
 	/* Davicom takes a bit to come up after a reset,
 	 * so wait here for a bit */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(timeout);
+	ssleep(timeout_secs);
 }
 
 static phy_info_t phy_info_dm9161 = {

  reply	other threads:[~2005-05-02  6:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-02  6:14 [KJ] [PATCH] net/3c505: replace schedule_timeout() with msleep() Nishanth Aravamudan
2005-05-02  6:14 ` Nishanth Aravamudan
2005-05-02  6:26 ` Nishanth Aravamudan [this message]
2005-05-02  6:26   ` [PATCH] ppc/fcc_enet: replace schedule_timeout() with ssleep() Nishanth Aravamudan
2005-05-02  6:34 ` [KJ] [PATCH] net/slip: replace schedule_timeout() with Nishanth Aravamudan
2005-05-02  6:34   ` [KJ] [PATCH] net/slip: replace schedule_timeout() with msleep_interruptible() Nishanth Aravamudan
  -- strict thread matches above, loose matches on Subject: below --
2005-05-02  6:18 [KJ] [PATCH] i386/apm: use wait_event_interruptible_timeout() Nishanth Aravamudan
2005-05-02  6:18 ` Nishanth Aravamudan
2005-05-03 21:40 ` [KJ] " Nishanth Aravamudan
2005-05-03 21:40   ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050502062600.GD10173@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=dmalek@jlc.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.