From: Andi Kleen <ak@muc.de>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fixing stack alignment in x86-64 Xen
Date: 18 May 2005 18:14:11 +0200
Date: Wed, 18 May 2005 18:14:11 +0200 [thread overview]
Message-ID: <20050518161411.GA88141@muc.de> (raw)
In-Reply-To: <7F740D512C7C1046AB53446D3720017304021E83@scsmsx402.amr.corp.intel.com>
> I think the right thing is to get rsp0 in TSS on a 16-byte boundary by
> getting get_stack_bottom() and get_cpu_user_regs() see the correct
> stack. That will fix the reset_stack_and_jump() as well. It's basically
> what my patch does.
This means you cannot disable the 16 byte stack alignment in gcc.
Probably does not matter too much today (I guess Xen is not that
bad a stack pig), but in the far future it might come in useful.
Also it would generate smaller code.
-Andi
next prev parent reply other threads:[~2005-05-18 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 15:57 [PATCH] Fixing stack alignment in x86-64 Xen Nakajima, Jun
2005-05-18 16:14 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-18 16:38 Nakajima, Jun
2005-05-18 15:09 Nakajima, Jun
2005-05-18 15:32 ` Andi Kleen
2005-05-18 7:36 Ian Pratt
2005-05-18 2:25 Nakajima, Jun
2005-05-18 5:07 ` Scott Parish
2005-05-18 7:35 ` Keir Fraser
2005-05-18 14:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518161411.GA88141@muc.de \
--to=ak@muc.de \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.