From: Andi Kleen <ak@muc.de>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fixing stack alignment in x86-64 Xen
Date: Wed, 18 May 2005 17:32:37 +0200 [thread overview]
Message-ID: <m1u0l04kiy.fsf@muc.de> (raw)
In-Reply-To: <7F740D512C7C1046AB53446D3720017304021DD7@scsmsx402.amr.corp.intel.com> (Jun Nakajima's message of "Wed, 18 May 2005 08:09:42 -0700")
"Nakajima, Jun" <jun.nakajima@intel.com> writes:
>
> The recent optimization reset_stack_and_jump() code needs to know the
> exact address of the interrupt stack (because it resets %rsp), and
> calculates it based on the value that Xen set (i.e. 8-byte boundary).
> Since the processor forces the rsp0 on a 16-byte boundary (i.e. moves it
> down by 8 bytes), Xen sees a wrong stack when returning from the
> interrupt.
I would rather fix reset_stack_and_jump then to do the necessary
rounding or better look at the original RSP the processor stored into the
stack frame. Otherwise the 16 byte alignment will probably bite you
later again.
-Andi
next prev parent reply other threads:[~2005-05-18 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 15:09 [PATCH] Fixing stack alignment in x86-64 Xen Nakajima, Jun
2005-05-18 15:32 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-18 16:38 Nakajima, Jun
2005-05-18 15:57 Nakajima, Jun
2005-05-18 16:14 ` Andi Kleen
2005-05-18 7:36 Ian Pratt
2005-05-18 2:25 Nakajima, Jun
2005-05-18 5:07 ` Scott Parish
2005-05-18 7:35 ` Keir Fraser
2005-05-18 14:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1u0l04kiy.fsf@muc.de \
--to=ak@muc.de \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.