From: Andi Kleen <ak@muc.de>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fixing stack alignment in x86-64 Xen
Date: Wed, 18 May 2005 16:06:18 +0200 [thread overview]
Message-ID: <m11x846339.fsf@muc.de> (raw)
In-Reply-To: <7F740D512C7C1046AB53446D3720017304021C2C@scsmsx402.amr.corp.intel.com> (Jun Nakajima's message of "Tue, 17 May 2005 19:25:46 -0700")
"Nakajima, Jun" <jun.nakajima@intel.com> writes:
> Long mode needs to align the stack on a 16-byte boundary. Recent changes
> to Xen broke the requirement, and x86-64 XenLinux stopped booting. The
> attached fixes the problem.
Normally it should be only needed in user space for saving FP registers.
The kernel and Xen which should not do this probably don't need it.
Unless you save FP registers on the stack somewhere. Then I would
rather fix that place only.
At least the main linux kernel does not try to keep the stack
always 16byte aligned. There is even a gcc option to turn it off
and it saves some code (and probably stack) size.
-Andi
next prev parent reply other threads:[~2005-05-18 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 2:25 [PATCH] Fixing stack alignment in x86-64 Xen Nakajima, Jun
2005-05-18 5:07 ` Scott Parish
2005-05-18 7:35 ` Keir Fraser
2005-05-18 14:06 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-18 7:36 Ian Pratt
2005-05-18 15:09 Nakajima, Jun
2005-05-18 15:32 ` Andi Kleen
2005-05-18 15:57 Nakajima, Jun
2005-05-18 16:14 ` Andi Kleen
2005-05-18 16:38 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11x846339.fsf@muc.de \
--to=ak@muc.de \
--cc=jun.nakajima@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.