[KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[Henry]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

Hi, this is my first patch for linux kernel. Don't know if its correct, please check. Its based on an item on the 
TODO list


Signed-off-by: Kouzinopoulos Haris <haris at mpa.gr>

--- linux/drivers/scsi/gdth.c	2005-05-28 02:38:23.000000000 +0300
+++ linux/drivers/scsi/gdth.c.patch	2005-05-28 03:02:33.000000000 +0300
@@ -388,6 +388,7 @@
 #include <linux/proc_fs.h>
 #include <linux/time.h>
 #include <linux/timer.h>
+#include <linux/dma-mapping.h>
 #ifdef GDTH_RTC
 #include <linux/mc146818rtc.h>
 #endif
@@ -4529,15 +4530,15 @@ static int __init gdth_detect(Scsi_Host_
             if (!(ha->cache_feat & ha->raw_feat & ha->screen_feat &GDT_64BIT)||
                 /* 64-bit DMA only supported from FW >= x.43 */
                 (!ha->dma64_support)) {
-                if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 32-bit DMA\n", hanum);
                     err = TRUE;
                 }
             } else {
                 shp->max_cmd_len = 16;
-                if (!pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffffffffffffULL)) {
+                if (!pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk("GDT-PCI %d: 64-bit DMA enabled\n", hanum);
-                } else if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                } else if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 64/32-bit DMA\n", hanum);
                     err = TRUE;
                 }

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[Dave Jones]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

On Sat, May 28, 2005 at 03:16:51AM +0300, Henry wrote:
 > -                if (!pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffffffffffffULL)) {
 > +                if (!pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {

This should be DMA_64BIT_MASK

		Dave

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[Tobias Klauser]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On Sat, May 28, 2005 at 03:16:51AM +0300, Henry wrote:
> Hi, this is my first patch for linux kernel. Don't know if its correct,
> please check. Its based on an item on the TODO list

I already submitted this patch [1] a while ago (with the correct constants).
Please check the archive at [2] before sending patches.

Thanks, Tobias

[1]
http://lists.osdl.org/pipermail/kernel-janitors/2005-March/003838.html
[2] http://lists.osdl.org/pipermail/kernel-janitors/

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[Henry]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Hey, sorry for the the mess. I'll be more carefull next time

Στις Σαβ 28 Μαι 2005 10:34, ο/η Tobias Klauser έγραψε:
> On Sat, May 28, 2005 at 03:16:51AM +0300, Henry wrote:
> > Hi, this is my first patch for linux kernel. Don't know if its correct,
> > please check. Its based on an item on the TODO list
> 
> I already submitted this patch [1] a while ago (with the correct constants).
> Please check the archive at [2] before sending patches.
> 
> Thanks, Tobias
> 
> [1]
> http://lists.osdl.org/pipermail/kernel-janitors/2005-March/003838.html
> [2] http://lists.osdl.org/pipermail/kernel-janitors/
> 


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Henry (haris@mpa.gr) wrote:
> Hi, this is my first patch for linux kernel. Don't know if its correct, please check. Its based on an item on the 
> TODO list

Patch alraedy submitted here by Tobias.

	~Christophe


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors