[PATCH] fix WANT_PAGE_VIRTUAL in memmap_init

[PATCH] fix WANT_PAGE_VIRTUAL in memmap_init

[Bob Picco]

I spotted this issue while in memmap_init last week.  I can't say the change has
any test coverage by me.  start_pfn was formerly used in main "for" loop.
The fix is replace start_pfn with pfn.

bob

Signed-off-by: Bob Picco <bob.picco@hp.com>

Index: linux-2.6.12-mm1/mm/page_alloc.c
===================================================================
--- linux-2.6.12-mm1.orig/mm/page_alloc.c	2005-06-23 14:18:09.000000000 -0400
+++ linux-2.6.12-mm1/mm/page_alloc.c	2005-06-23 14:19:46.000000000 -0400
@@ -1720,9 +1720,8 @@ void __init memmap_init_zone(unsigned lo
 #ifdef WANT_PAGE_VIRTUAL
 		/* The shift won't overflow because ZONE_NORMAL is below 4G. */
 		if (!is_highmem_idx(zone))
-			set_page_address(page, __va(start_pfn << PAGE_SHIFT));
+			set_page_address(page, __va(pfn << PAGE_SHIFT));
 #endif
-		start_pfn++;
 #ifdef CONFIG_PAGE_OWNER
 		page->order = -1;
 #endif
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

Re: [PATCH] fix WANT_PAGE_VIRTUAL in memmap_init

[William Lee Irwin III]

On Mon, Jun 27, 2005 at 06:58:29AM -0400, Bob Picco wrote:
> I spotted this issue while in memmap_init last week.  I can't say the
> change has any test coverage by me.  start_pfn was formerly used in
> main "for" loop. The fix is replace start_pfn with pfn.

Bob, this is rather serious. Could you push this to -STABLE after it
goes to mainline (which hopefully is ASAP)?

Thanks.


-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

Re: [PATCH] fix WANT_PAGE_VIRTUAL in memmap_init

[William Lee Irwin III]

On Mon, Jun 27, 2005 at 06:58:29AM -0400, Bob Picco wrote:
>> I spotted this issue while in memmap_init last week.  I can't say the
>> change has any test coverage by me.  start_pfn was formerly used in
>> main "for" loop. The fix is replace start_pfn with pfn.

On Mon, Jun 27, 2005 at 05:58:05AM -0700, William Lee Irwin III wrote:
> Bob, this is rather serious. Could you push this to -STABLE after it
> goes to mainline (which hopefully is ASAP)?

False alarm, it's just a redundant counter (it's not even 6AM here).
Looks like someone took a dump all over this code recently. Brilliant.


-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>