[KJ] [PATCH] bonding - a trailing whitespace

[KJ] [PATCH] bonding - a trailing whitespace

[Carlo Perassi]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

A trailing whitespace found making a previuos patch on the same file

Signed-off-by: Carlo Perassi <carlo@linux.it>
---
 drivers/net/bonding/bond_main.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.12/drivers/net/bonding/bond_main.c
===================================================================
--- linux-2.6.12.orig/drivers/net/bonding/bond_main.c
+++ linux-2.6.12/drivers/net/bonding/bond_main.c
@@ -572,7 +572,7 @@
 static struct proc_dir_entry *bond_proc_dir = NULL;
 #endif
 
-static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
+static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, };
 static int arp_ip_count;
 static u32 my_ip	= 0;
 static int bond_mode	= BOND_MODE_ROUNDROBIN;

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] bonding - a trailing whitespace

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

On 23/06/05 21:30 +0200, Carlo Perassi wrote:
> A trailing whitespace found making a previuos patch on the same file
> 
> Signed-off-by: Carlo Perassi <carlo@linux.it>
> ---
> +++ linux-2.6.12/drivers/net/bonding/bond_main.c
> @@ -572,7 +572,7 @@
>  static struct proc_dir_entry *bond_proc_dir = NULL;
>  #endif
>  
> -static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
> +static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, };

Why not just
	static u32 arp_target[BOND_MAX_ARP_TARGETS];
... and include in the uninitialize static variables patch?

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] bonding - a trailing whitespace

[Carlo Perassi]

> Why not just
> 	static u32 arp_target[BOND_MAX_ARP_TARGETS];
> ... and include in the uninitialize static variables patch?

it is already included in
[PATCH] [RESEND] bonding - uninitialize static variables
Sat Jun 25 12:05:09 PDT 2005
http://lists.osdl.org/pipermail/kernel-janitors/2005-June/004268.html

-- 
Carlo Perassi - http://www.linux.it/~carlo/

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] bonding - a trailing whitespace

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

On 28/06/05 15:47 +0200, Carlo Perassi wrote:
> > Why not just
> > 	static u32 arp_target[BOND_MAX_ARP_TARGETS];
> > ... and include in the uninitialize static variables patch?
> 
> it is already included in
> [PATCH] [RESEND] bonding - uninitialize static variables

Jup, just noticed, sorry.
(Note to self: read mails from bottom up)

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors