* [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of
@ 2005-07-12 12:07 Christophe Lucas
2005-07-12 12:28 ` Domen Puncer
2005-07-12 16:57 ` Christophe Lucas
0 siblings, 2 replies; 3+ messages in thread
From: Christophe Lucas @ 2005-07-12 12:07 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Description:
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
===================================================================
--- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
+++ 2.6.13-rc1/arch/arm/kernel/ecard.c
@@ -776,9 +776,16 @@ static struct proc_dir_entry *proc_bus_e
static void ecard_proc_init(void)
{
+ struct proc_dir_entry *proc_entry;
+
proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
- create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
+ if (proc_bus_ecard_dir == NULL)
+ printk(KERN_WARNING
+ "ecard: Unable to create proc dir entry.\n");
+ proc_entry = create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
get_ecard_dev_info);
+ if (proc_entry == NULL)
+ printk(KERN_WARNING "ecard: Unable to create proc entry.\n");
}
#define ec_set_resource(ec,nr,st,sz) \
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of
2005-07-12 12:07 [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of Christophe Lucas
@ 2005-07-12 12:28 ` Domen Puncer
2005-07-12 16:57 ` Christophe Lucas
1 sibling, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2005-07-12 12:28 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On 12/07/05 14:07 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
>
> Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
> ===================================================================
> --- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
> +++ 2.6.13-rc1/arch/arm/kernel/ecard.c
> @@ -776,9 +776,16 @@ static struct proc_dir_entry *proc_bus_e
>
> static void ecard_proc_init(void)
> {
> + struct proc_dir_entry *proc_entry;
> +
> proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
> - create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
> + if (proc_bus_ecard_dir == NULL)
> + printk(KERN_WARNING
> + "ecard: Unable to create proc dir entry.\n");
> + proc_entry = create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
I don' think this is intended if proc_bus_ecard_dir is NULL.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of
2005-07-12 12:07 [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of Christophe Lucas
2005-07-12 12:28 ` Domen Puncer
@ 2005-07-12 16:57 ` Christophe Lucas
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Lucas @ 2005-07-12 16:57 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Description:
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
===================================================================
--- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
+++ 2.6.13-rc1/arch/arm/kernel/ecard.c
@@ -776,9 +776,19 @@ static struct proc_dir_entry *proc_bus_e
static void ecard_proc_init(void)
{
+ struct proc_dir_entry *proc_entry;
+
proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
- create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
- get_ecard_dev_info);
+ if (proc_bus_ecard_dir == NULL)
+ printk(KERN_WARNING
+ "ecard: Unable to create proc dir entry.\n");
+ else {
+ proc_entry = create_proc_info_entry("devices", 0,
+ proc_bus_ecard_dir, get_ecard_dev_info);
+ if (proc_entry == NULL)
+ printk(KERN_WARNING
+ "ecard: Unable to create proc entry.\n");
+ }
}
#define ec_set_resource(ec,nr,st,sz) \
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-12 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-12 12:07 [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of Christophe Lucas
2005-07-12 12:28 ` Domen Puncer
2005-07-12 16:57 ` Christophe Lucas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.