[KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of

[KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

Description:
Audit return of create_proc_* functions.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
===================================================================
--- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
+++ 2.6.13-rc1/arch/arm/kernel/ecard.c
@@ -776,9 +776,16 @@ static struct proc_dir_entry *proc_bus_e
 
 static void ecard_proc_init(void)
 {
+	struct proc_dir_entry *proc_entry;
+
 	proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
-	create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
+	if (proc_bus_ecard_dir == NULL)
+		printk(KERN_WARNING 
+			"ecard: Unable to create proc dir entry.\n");
+	proc_entry = create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
 		get_ecard_dev_info);
+	if (proc_entry == NULL) 
+		printk(KERN_WARNING "ecard: Unable to create proc entry.\n");
 }
 
 #define ec_set_resource(ec,nr,st,sz)				\

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On 12/07/05 14:07 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions.
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
> ===================================================================
> --- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
> +++ 2.6.13-rc1/arch/arm/kernel/ecard.c
> @@ -776,9 +776,16 @@ static struct proc_dir_entry *proc_bus_e
>  
>  static void ecard_proc_init(void)
>  {
> +	struct proc_dir_entry *proc_entry;
> +
>  	proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
> -	create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
> +	if (proc_bus_ecard_dir == NULL)
> +		printk(KERN_WARNING 
> +			"ecard: Unable to create proc dir entry.\n");
> +	proc_entry = create_proc_info_entry("devices", 0, proc_bus_ecard_dir,

I don' think this is intended if proc_bus_ecard_dir is NULL.


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [patch 2.6.13-rc1 21/23][RESEND] Audit return code of

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

Description:
Audit return of create_proc_* functions.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Index: 2.6.13-rc1/arch/arm/kernel/ecard.c
===================================================================
--- 2.6.13-rc1.orig/arch/arm/kernel/ecard.c
+++ 2.6.13-rc1/arch/arm/kernel/ecard.c
@@ -776,9 +776,19 @@ static struct proc_dir_entry *proc_bus_e
 
 static void ecard_proc_init(void)
 {
+	struct proc_dir_entry *proc_entry;
+
 	proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
-	create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
-		get_ecard_dev_info);
+	if (proc_bus_ecard_dir == NULL)
+		printk(KERN_WARNING 
+			"ecard: Unable to create proc dir entry.\n");
+	else {
+		proc_entry = create_proc_info_entry("devices", 0, 
+			proc_bus_ecard_dir, get_ecard_dev_info);
+		if (proc_entry == NULL) 
+			printk(KERN_WARNING 
+				"ecard: Unable to create proc entry.\n");
+	}
 }
 
 #define ec_set_resource(ec,nr,st,sz)				\

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors