All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Keith Owens <kaos@ocs.com.au>,
	David.Mosberger@acm.org, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: Add prefetch switch stack hook in scheduler function
Date: Fri, 29 Jul 2005 08:35:58 +0000	[thread overview]
Message-ID: <20050729083558.GA7302@elte.hu> (raw)
In-Reply-To: <200507290830.j6T8Ugg08348@unix-os.sc.intel.com>


* Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:

> Ingo Molnar wrote on Friday, July 29, 2005 12:07 AM
> > the patch below unrolls the prefetch_range() loop manually, for up to 5 
> > cachelines prefetched. This patch, ontop of the 4 previous patches, 
> > should generate similar code to the assembly code in your original 
> > patch. The full patch-series is:
> 
> It generate slight different code because previous patch asks for a little
> over 5 cache lines worth of bytes and it always go to the for loop.

ok - fix below. But i'm not that sure we want to unroll a 6-instruction 
loop, and it's getting a bit ugly. (Also, it would be nice to have a gcc 
extension for loops that says 'always unroll up to N entries'.)

	Ingo

----
unroll the prefetch loop some more.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

 include/linux/prefetch.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+)

Index: linux-prefetch-task/include/linux/prefetch.h
=================================--- linux-prefetch-task.orig/include/linux/prefetch.h
+++ linux-prefetch-task/include/linux/prefetch.h
@@ -87,6 +87,14 @@ static inline void prefetch_range(void *
 		prefetch(cp + 2*PREFETCH_STRIDE);
 		prefetch(cp + 3*PREFETCH_STRIDE);
 		prefetch(cp + 4*PREFETCH_STRIDE);
+	}
+	else if (len <= 6*PREFETCH_STRIDE) {
+		prefetch(cp);
+		prefetch(cp + PREFETCH_STRIDE);
+		prefetch(cp + 2*PREFETCH_STRIDE);
+		prefetch(cp + 3*PREFETCH_STRIDE);
+		prefetch(cp + 4*PREFETCH_STRIDE);
+		prefetch(cp + 5*PREFETCH_STRIDE);
 	} else
 		for (; cp < end; cp += PREFETCH_STRIDE)
 			prefetch(cp);
@@ -125,6 +133,14 @@ static inline void prefetchw_range(void 
 		prefetchw(cp + 2*PREFETCH_STRIDE);
 		prefetchw(cp + 3*PREFETCH_STRIDE);
 		prefetchw(cp + 4*PREFETCH_STRIDE);
+	}
+	else if (len <= 6*PREFETCH_STRIDE) {
+		prefetchw(cp);
+		prefetchw(cp + PREFETCH_STRIDE);
+		prefetchw(cp + 2*PREFETCH_STRIDE);
+		prefetchw(cp + 3*PREFETCH_STRIDE);
+		prefetchw(cp + 4*PREFETCH_STRIDE);
+		prefetchw(cp + 5*PREFETCH_STRIDE);
 	} else
 		for (; cp < end; cp += PREFETCH_STRIDE)
 			prefetchw(cp);

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Keith Owens <kaos@ocs.com.au>,
	David.Mosberger@acm.org, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: Add prefetch switch stack hook in scheduler function
Date: Fri, 29 Jul 2005 10:35:58 +0200	[thread overview]
Message-ID: <20050729083558.GA7302@elte.hu> (raw)
In-Reply-To: <200507290830.j6T8Ugg08348@unix-os.sc.intel.com>


* Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:

> Ingo Molnar wrote on Friday, July 29, 2005 12:07 AM
> > the patch below unrolls the prefetch_range() loop manually, for up to 5 
> > cachelines prefetched. This patch, ontop of the 4 previous patches, 
> > should generate similar code to the assembly code in your original 
> > patch. The full patch-series is:
> 
> It generate slight different code because previous patch asks for a little
> over 5 cache lines worth of bytes and it always go to the for loop.

ok - fix below. But i'm not that sure we want to unroll a 6-instruction 
loop, and it's getting a bit ugly. (Also, it would be nice to have a gcc 
extension for loops that says 'always unroll up to N entries'.)

	Ingo

----
unroll the prefetch loop some more.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

 include/linux/prefetch.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+)

Index: linux-prefetch-task/include/linux/prefetch.h
===================================================================
--- linux-prefetch-task.orig/include/linux/prefetch.h
+++ linux-prefetch-task/include/linux/prefetch.h
@@ -87,6 +87,14 @@ static inline void prefetch_range(void *
 		prefetch(cp + 2*PREFETCH_STRIDE);
 		prefetch(cp + 3*PREFETCH_STRIDE);
 		prefetch(cp + 4*PREFETCH_STRIDE);
+	}
+	else if (len <= 6*PREFETCH_STRIDE) {
+		prefetch(cp);
+		prefetch(cp + PREFETCH_STRIDE);
+		prefetch(cp + 2*PREFETCH_STRIDE);
+		prefetch(cp + 3*PREFETCH_STRIDE);
+		prefetch(cp + 4*PREFETCH_STRIDE);
+		prefetch(cp + 5*PREFETCH_STRIDE);
 	} else
 		for (; cp < end; cp += PREFETCH_STRIDE)
 			prefetch(cp);
@@ -125,6 +133,14 @@ static inline void prefetchw_range(void 
 		prefetchw(cp + 2*PREFETCH_STRIDE);
 		prefetchw(cp + 3*PREFETCH_STRIDE);
 		prefetchw(cp + 4*PREFETCH_STRIDE);
+	}
+	else if (len <= 6*PREFETCH_STRIDE) {
+		prefetchw(cp);
+		prefetchw(cp + PREFETCH_STRIDE);
+		prefetchw(cp + 2*PREFETCH_STRIDE);
+		prefetchw(cp + 3*PREFETCH_STRIDE);
+		prefetchw(cp + 4*PREFETCH_STRIDE);
+		prefetchw(cp + 5*PREFETCH_STRIDE);
 	} else
 		for (; cp < end; cp += PREFETCH_STRIDE)
 			prefetchw(cp);

  reply	other threads:[~2005-07-29  8:35 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27 22:07 Add prefetch switch stack hook in scheduler function Chen, Kenneth W
2005-07-27 22:07 ` Chen, Kenneth W
2005-07-27 23:13 ` Andrew Morton
2005-07-27 23:13   ` Andrew Morton
2005-07-27 23:23   ` david mosberger
2005-07-27 23:23     ` david mosberger
2005-07-28  7:41     ` Ingo Molnar
2005-07-28  7:41       ` Ingo Molnar
2005-07-28  8:09 ` Keith Owens
2005-07-28  8:09   ` Keith Owens
2005-07-28  8:16   ` Ingo Molnar
2005-07-28  8:16     ` Ingo Molnar
2005-07-28  9:09     ` Ingo Molnar
2005-07-28  9:09       ` Ingo Molnar
2005-07-28  8:31   ` Nick Piggin
2005-07-28  8:31     ` Nick Piggin
2005-07-28  8:35     ` Ingo Molnar
2005-07-28  8:35       ` Ingo Molnar
2005-07-28  8:48       ` Nick Piggin
2005-07-28  8:48         ` Nick Piggin
2005-07-28  9:16         ` Ingo Molnar
2005-07-28  9:16           ` Ingo Molnar
2005-07-28  9:19           ` Ingo Molnar
2005-07-28  9:19             ` Ingo Molnar
2005-07-28  9:34           ` Nick Piggin
2005-07-28  9:34             ` Nick Piggin
2005-07-28 10:04             ` Ingo Molnar
2005-07-28 10:04               ` Ingo Molnar
2005-07-28 10:29               ` Nick Piggin
2005-07-28 10:29                 ` Nick Piggin
2005-07-28 19:14 ` Chen, Kenneth W
2005-07-28 19:14   ` Chen, Kenneth W
2005-07-29  7:04   ` Ingo Molnar
2005-07-29  7:04     ` Ingo Molnar
2005-07-29  7:07     ` Ingo Molnar
2005-07-29  7:07       ` Ingo Molnar
2005-07-29  8:30       ` Eric Dumazet
2005-07-29  8:30         ` Eric Dumazet
2005-07-29  8:44         ` Ingo Molnar
2005-07-29  8:44           ` Ingo Molnar
2005-07-31 16:27         ` hashed spinlocks Daniel Walker
2005-07-31 18:46           ` David S. Miller
2005-07-31 19:06             ` Daniel Walker
2005-07-31 19:11               ` David S. Miller
2005-07-31 19:16                 ` Daniel Walker
2005-07-29  9:17       ` Add prefetch switch stack hook in scheduler function Peter Zijlstra
2005-07-29  9:17         ` Peter Zijlstra
2005-07-29 10:52         ` Ingo Molnar
2005-07-29 10:52           ` Ingo Molnar
2005-07-29  7:22 ` Chen, Kenneth W
2005-07-29  7:22   ` Chen, Kenneth W
2005-07-29  8:28   ` Ingo Molnar
2005-07-29  8:28     ` Ingo Molnar
2005-07-29  9:02     ` Russell King
2005-07-29  9:02       ` Russell King
2005-07-29  9:45       ` Ingo Molnar
2005-07-29  9:45         ` Ingo Molnar
2005-07-29  7:38 ` Keith Owens
2005-07-29  7:38   ` Keith Owens
2005-07-29  7:45 ` Keith Owens
2005-07-29  7:45   ` Keith Owens
2005-07-29  8:02 ` Chen, Kenneth W
2005-07-29  8:02   ` Chen, Kenneth W
2005-07-29  8:08 ` Chen, Kenneth W
2005-07-29  8:08   ` Chen, Kenneth W
2005-07-29  8:30 ` Chen, Kenneth W
2005-07-29  8:30   ` Chen, Kenneth W
2005-07-29  8:35   ` Ingo Molnar [this message]
2005-07-29  8:35     ` Ingo Molnar
2005-07-29  8:39 ` Chen, Kenneth W
2005-07-29  8:39   ` Chen, Kenneth W
  -- strict thread matches above, loose matches on Subject: below --
2005-07-29 15:18 linux
2005-07-29 15:49 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050729083558.GA7302@elte.hu \
    --to=mingo@elte.hu \
    --cc=David.Mosberger@acm.org \
    --cc=akpm@osdl.org \
    --cc=kaos@ocs.com.au \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.