All of lore.kernel.org
 help / color / mirror / Atom feed
From: david mosberger <dmosberger@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	mingo@elte.hu, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: Re: Add prefetch switch stack hook in scheduler function
Date: Wed, 27 Jul 2005 23:23:37 +0000	[thread overview]
Message-ID: <ed5aea4305072716233491f7f8@mail.gmail.com> (raw)
In-Reply-To: <20050727161316.0593d762.akpm@osdl.org>

Also, should this be called prefetch_stack() or perhaps even just
prefetch_task()?  Not every architecture defines a switch_stack
structure.

  --david

-- 
Mosberger Consulting LLC, voice/fax: 510-744-9372,
http://www.mosberger-consulting.com/
35706 Runckel Lane, Fremont, CA 94536

On 7/27/05, Andrew Morton <akpm@osdl.org> wrote:
> "Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:
> >
> > +#ifdef ARCH_HAS_PREFETCH_SWITCH_STACK
> >  +extern void prefetch_switch_stack(struct task_struct*);
> >  +#else
> >  +#define prefetch_switch_stack(task) do { } while (0)
> >  +#endif
> 
> It is better to use
> 
> static inline void prefetch_switch_stack(struct task_struct *t) { }
> 
> in the second case, rather than a macro.  It provides typechecking.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

WARNING: multiple messages have this Message-ID (diff)
From: david mosberger <dmosberger@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	mingo@elte.hu, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: Re: Add prefetch switch stack hook in scheduler function
Date: Wed, 27 Jul 2005 16:23:37 -0700	[thread overview]
Message-ID: <ed5aea4305072716233491f7f8@mail.gmail.com> (raw)
In-Reply-To: <20050727161316.0593d762.akpm@osdl.org>

Also, should this be called prefetch_stack() or perhaps even just
prefetch_task()?  Not every architecture defines a switch_stack
structure.

  --david

-- 
Mosberger Consulting LLC, voice/fax: 510-744-9372,
http://www.mosberger-consulting.com/
35706 Runckel Lane, Fremont, CA 94536

On 7/27/05, Andrew Morton <akpm@osdl.org> wrote:
> "Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:
> >
> > +#ifdef ARCH_HAS_PREFETCH_SWITCH_STACK
> >  +extern void prefetch_switch_stack(struct task_struct*);
> >  +#else
> >  +#define prefetch_switch_stack(task) do { } while (0)
> >  +#endif
> 
> It is better to use
> 
> static inline void prefetch_switch_stack(struct task_struct *t) { }
> 
> in the second case, rather than a macro.  It provides typechecking.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2005-07-27 23:23 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27 22:07 Add prefetch switch stack hook in scheduler function Chen, Kenneth W
2005-07-27 22:07 ` Chen, Kenneth W
2005-07-27 23:13 ` Andrew Morton
2005-07-27 23:13   ` Andrew Morton
2005-07-27 23:23   ` david mosberger [this message]
2005-07-27 23:23     ` david mosberger
2005-07-28  7:41     ` Ingo Molnar
2005-07-28  7:41       ` Ingo Molnar
2005-07-28  8:09 ` Keith Owens
2005-07-28  8:09   ` Keith Owens
2005-07-28  8:16   ` Ingo Molnar
2005-07-28  8:16     ` Ingo Molnar
2005-07-28  9:09     ` Ingo Molnar
2005-07-28  9:09       ` Ingo Molnar
2005-07-28  8:31   ` Nick Piggin
2005-07-28  8:31     ` Nick Piggin
2005-07-28  8:35     ` Ingo Molnar
2005-07-28  8:35       ` Ingo Molnar
2005-07-28  8:48       ` Nick Piggin
2005-07-28  8:48         ` Nick Piggin
2005-07-28  9:16         ` Ingo Molnar
2005-07-28  9:16           ` Ingo Molnar
2005-07-28  9:19           ` Ingo Molnar
2005-07-28  9:19             ` Ingo Molnar
2005-07-28  9:34           ` Nick Piggin
2005-07-28  9:34             ` Nick Piggin
2005-07-28 10:04             ` Ingo Molnar
2005-07-28 10:04               ` Ingo Molnar
2005-07-28 10:29               ` Nick Piggin
2005-07-28 10:29                 ` Nick Piggin
2005-07-28 19:14 ` Chen, Kenneth W
2005-07-28 19:14   ` Chen, Kenneth W
2005-07-29  7:04   ` Ingo Molnar
2005-07-29  7:04     ` Ingo Molnar
2005-07-29  7:07     ` Ingo Molnar
2005-07-29  7:07       ` Ingo Molnar
2005-07-29  8:30       ` Eric Dumazet
2005-07-29  8:30         ` Eric Dumazet
2005-07-29  8:44         ` Ingo Molnar
2005-07-29  8:44           ` Ingo Molnar
2005-07-31 16:27         ` hashed spinlocks Daniel Walker
2005-07-31 18:46           ` David S. Miller
2005-07-31 19:06             ` Daniel Walker
2005-07-31 19:11               ` David S. Miller
2005-07-31 19:16                 ` Daniel Walker
2005-07-29  9:17       ` Add prefetch switch stack hook in scheduler function Peter Zijlstra
2005-07-29  9:17         ` Peter Zijlstra
2005-07-29 10:52         ` Ingo Molnar
2005-07-29 10:52           ` Ingo Molnar
2005-07-29  7:22 ` Chen, Kenneth W
2005-07-29  7:22   ` Chen, Kenneth W
2005-07-29  8:28   ` Ingo Molnar
2005-07-29  8:28     ` Ingo Molnar
2005-07-29  9:02     ` Russell King
2005-07-29  9:02       ` Russell King
2005-07-29  9:45       ` Ingo Molnar
2005-07-29  9:45         ` Ingo Molnar
2005-07-29  7:38 ` Keith Owens
2005-07-29  7:38   ` Keith Owens
2005-07-29  7:45 ` Keith Owens
2005-07-29  7:45   ` Keith Owens
2005-07-29  8:02 ` Chen, Kenneth W
2005-07-29  8:02   ` Chen, Kenneth W
2005-07-29  8:08 ` Chen, Kenneth W
2005-07-29  8:08   ` Chen, Kenneth W
2005-07-29  8:30 ` Chen, Kenneth W
2005-07-29  8:30   ` Chen, Kenneth W
2005-07-29  8:35   ` Ingo Molnar
2005-07-29  8:35     ` Ingo Molnar
2005-07-29  8:39 ` Chen, Kenneth W
2005-07-29  8:39   ` Chen, Kenneth W
  -- strict thread matches above, loose matches on Subject: below --
2005-07-29 15:18 linux
2005-07-29 15:49 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed5aea4305072716233491f7f8@mail.gmail.com \
    --to=dmosberger@gmail.com \
    --cc=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.