From: Olaf Hering <olh@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: bboissin@gmail.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] implicit declaration of function `page_cache_release'
Date: Sat, 06 Aug 2005 15:01:03 +0000 [thread overview]
Message-ID: <20050806150103.GA21821@suse.de> (raw)
In-Reply-To: <20050806.065520.85401639.davem@davemloft.net>
On Sat, Aug 06, David S. Miller wrote:
> From: Benoit Boissinot <bboissin@gmail.com>
> Date: Fri, 5 Aug 2005 21:18:38 +0200
>
> > On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> > > On Fri, Aug 05, Benoit Boissinot wrote:
> > >
> > > Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
> > >
> > sparc is the only architecture to do that, it looks like it uses it
> > for boot time linking (BTFIXUP_*). I don't know anything about sparc,
> > so i can't fix it.
> >
> > (adding sparclinux@vger.kernel.org to the cc list)
>
> It needs to have the swp_entry_t type fully visible in pgtable.h,
> we can't work around this using macros.
So the patch should be reverted? Its only for CONFIG_SWAP=n, rather
unusual for KDE/GNOME tainted workstations...
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olh@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: bboissin@gmail.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] implicit declaration of function `page_cache_release'
Date: Sat, 6 Aug 2005 17:01:03 +0200 [thread overview]
Message-ID: <20050806150103.GA21821@suse.de> (raw)
In-Reply-To: <20050806.065520.85401639.davem@davemloft.net>
On Sat, Aug 06, David S. Miller wrote:
> From: Benoit Boissinot <bboissin@gmail.com>
> Date: Fri, 5 Aug 2005 21:18:38 +0200
>
> > On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> > > On Fri, Aug 05, Benoit Boissinot wrote:
> > >
> > > Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
> > >
> > sparc is the only architecture to do that, it looks like it uses it
> > for boot time linking (BTFIXUP_*). I don't know anything about sparc,
> > so i can't fix it.
> >
> > (adding sparclinux@vger.kernel.org to the cc list)
>
> It needs to have the swp_entry_t type fully visible in pgtable.h,
> we can't work around this using macros.
So the patch should be reverted? Its only for CONFIG_SWAP=n, rather
unusual for KDE/GNOME tainted workstations...
next prev parent reply other threads:[~2005-08-06 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 15:03 [PATCH] implicit declaration of function `page_cache_release' Olaf Hering
2005-07-08 20:31 ` Andrew Morton
2005-07-08 20:35 ` Olaf Hering
2005-08-05 18:51 ` Benoit Boissinot
2005-08-05 19:00 ` Olaf Hering
2005-08-05 19:18 ` Benoit Boissinot
2005-08-05 19:18 ` Benoit Boissinot
2005-08-06 13:55 ` David S. Miller
2005-08-06 13:55 ` David S. Miller
2005-08-06 15:01 ` Olaf Hering [this message]
2005-08-06 15:01 ` Olaf Hering
2005-08-06 15:49 ` David S. Miller
2005-08-06 15:49 ` David S. Miller
2006-05-22 7:11 ` Olaf Hering
2006-05-22 7:11 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050806150103.GA21821@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=bboissin@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.