From: Benoit Boissinot <bboissin@gmail.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] implicit declaration of function `page_cache_release'
Date: Fri, 05 Aug 2005 19:18:38 +0000 [thread overview]
Message-ID: <40f323d00508051218c30d7af@mail.gmail.com> (raw)
In-Reply-To: <20050805190006.GA6747@suse.de>
On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> On Fri, Aug 05, Benoit Boissinot wrote:
>
> > On 7/8/05, Olaf Hering <olh@suse.de> wrote:
> > >
> > > In file included from include2/asm/tlb.h:31,
> > > from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> > >
> > This went in 2.6.13-rc3 (commit
> > 542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
> > because of the following circular dependency:
> > asm-sparc/pgtable include linux/swap.h
>
> Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
>
sparc is the only architecture to do that, it looks like it uses it
for boot time linking (BTFIXUP_*). I don't know anything about sparc,
so i can't fix it.
(adding sparclinux@vger.kernel.org to the cc list)
WARNING: multiple messages have this Message-ID (diff)
From: Benoit Boissinot <bboissin@gmail.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] implicit declaration of function `page_cache_release'
Date: Fri, 5 Aug 2005 21:18:38 +0200 [thread overview]
Message-ID: <40f323d00508051218c30d7af@mail.gmail.com> (raw)
In-Reply-To: <20050805190006.GA6747@suse.de>
On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> On Fri, Aug 05, Benoit Boissinot wrote:
>
> > On 7/8/05, Olaf Hering <olh@suse.de> wrote:
> > >
> > > In file included from include2/asm/tlb.h:31,
> > > from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> > >
> > This went in 2.6.13-rc3 (commit
> > 542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
> > because of the following circular dependency:
> > asm-sparc/pgtable include linux/swap.h
>
> Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
>
sparc is the only architecture to do that, it looks like it uses it
for boot time linking (BTFIXUP_*). I don't know anything about sparc,
so i can't fix it.
(adding sparclinux@vger.kernel.org to the cc list)
next prev parent reply other threads:[~2005-08-05 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 15:03 [PATCH] implicit declaration of function `page_cache_release' Olaf Hering
2005-07-08 20:31 ` Andrew Morton
2005-07-08 20:35 ` Olaf Hering
2005-08-05 18:51 ` Benoit Boissinot
2005-08-05 19:00 ` Olaf Hering
2005-08-05 19:18 ` Benoit Boissinot [this message]
2005-08-05 19:18 ` Benoit Boissinot
2005-08-06 13:55 ` David S. Miller
2005-08-06 13:55 ` David S. Miller
2005-08-06 15:01 ` Olaf Hering
2005-08-06 15:01 ` Olaf Hering
2005-08-06 15:49 ` David S. Miller
2005-08-06 15:49 ` David S. Miller
2006-05-22 7:11 ` Olaf Hering
2006-05-22 7:11 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f323d00508051218c30d7af@mail.gmail.com \
--to=bboissin@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.