From: Ingo Molnar <mingo@elte.hu>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
nickpiggin@yahoo.com.au, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@osdl.org, hawkes@sgi.com,
dino@in.ibm.com
Subject: Re: [PATCH 2.6.13-rc6] cpu_exclusive sched domains on partial nodes temp fix
Date: Tue, 23 Aug 2005 08:10:35 +0000 [thread overview]
Message-ID: <20050823081035.GA1346@elte.hu> (raw)
In-Reply-To: <20050823080427.14740.20177.sendpatchset@jackhammer.engr.sgi.com>
* Paul Jackson <pj@sgi.com> wrote:
> /*
> + * Hack to avoid 2.6.13 partial node dynamic sched domain bug.
> + * Require the 'cpu_exclusive' cpuset to include all (or none)
> + * of the CPUs on each node, or return w/o changing sched domains.
> + * Remove this hack when dynamic sched domains fixed.
> + */
> + {
> + int i, j;
> +
> + for_each_cpu_mask(i, cur->cpus_allowed) {
> + for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
> + if (!cpu_isset(j, cur->cpus_allowed))
> + return;
> + }
> + }
> + }
> +
certainly looks acceptable from a scheduler POV.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
nickpiggin@yahoo.com.au, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@osdl.org, hawkes@sgi.com,
dino@in.ibm.com
Subject: Re: [PATCH 2.6.13-rc6] cpu_exclusive sched domains on partial nodes temp fix
Date: Tue, 23 Aug 2005 10:10:35 +0200 [thread overview]
Message-ID: <20050823081035.GA1346@elte.hu> (raw)
In-Reply-To: <20050823080427.14740.20177.sendpatchset@jackhammer.engr.sgi.com>
* Paul Jackson <pj@sgi.com> wrote:
> /*
> + * Hack to avoid 2.6.13 partial node dynamic sched domain bug.
> + * Require the 'cpu_exclusive' cpuset to include all (or none)
> + * of the CPUs on each node, or return w/o changing sched domains.
> + * Remove this hack when dynamic sched domains fixed.
> + */
> + {
> + int i, j;
> +
> + for_each_cpu_mask(i, cur->cpus_allowed) {
> + for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
> + if (!cpu_isset(j, cur->cpus_allowed))
> + return;
> + }
> + }
> + }
> +
certainly looks acceptable from a scheduler POV.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2005-08-23 8:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 8:04 [PATCH 2.6.13-rc6] cpu_exclusive sched domains on partial nodes temp fix Paul Jackson
2005-08-23 8:04 ` Paul Jackson
2005-08-23 8:10 ` Ingo Molnar [this message]
2005-08-23 8:10 ` Ingo Molnar
2005-08-23 15:07 ` Dinakar Guniguntala
2005-08-23 15:19 ` Dinakar Guniguntala
2005-08-24 0:19 ` John Hawkes
2005-08-24 0:19 ` John Hawkes
2005-08-24 11:15 ` [PATCH 2.6.13-rc6] cpu_exclusive sched domains build fix Paul Jackson
2005-08-24 11:15 ` Paul Jackson
2005-08-24 11:26 ` Dinakar Guniguntala
2005-08-24 11:38 ` Dinakar Guniguntala
2005-08-24 11:46 ` Paul Jackson
2005-08-24 11:46 ` Paul Jackson
2005-08-24 12:01 ` Nick Piggin
2005-08-24 12:01 ` Nick Piggin
2005-08-24 20:31 ` Paul Jackson
2005-08-24 20:31 ` Paul Jackson
2005-08-25 0:02 ` Nick Piggin
2005-08-25 0:02 ` Nick Piggin
2005-08-25 0:57 ` Paul Jackson
2005-08-25 0:57 ` Paul Jackson
2005-08-25 14:41 ` Dinakar Guniguntala
2005-08-25 14:53 ` Dinakar Guniguntala
2005-08-25 15:20 ` Paul Jackson
2005-08-25 15:20 ` Paul Jackson
2005-08-24 16:09 ` John Hawkes
2005-08-24 16:09 ` John Hawkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050823081035.GA1346@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=hawkes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.