From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Rusty Lynch <rusty@linux.intel.com>,
"Lynch, Rusty" <rusty.lynch@intel.com>,
linux-mm@kvack.org, prasanna@in.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Date: Wed, 31 Aug 2005 00:05:00 +0000 [thread overview]
Message-ID: <200508310205.00965.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0508301642570.20548@schroedinger.engr.sgi.com>
On Wednesday 31 August 2005 01:54, Christoph Lameter wrote:
> Certainly not a big effect (if we make sure the compiler knows that
> this test mostly fails and insure that the variable is in
> __mostly_read)
Currently neither, but that could be easily fixed.
> but this is a frequently executed code path and the code
> is there without purpose if CONFIG_KPROBES is off.
Well if you really worry about it then it might be better to do some dynamic
code patching to make generic and distribution kernels too.
> It wont get too bad unless lots of other people have similar ideas about
> fixing their race conditions using similar methods. But we will be setting
> a bad precedent if we allow this.
Agreed on the general direction, but I didn't see an alternative
for kprobes for this. Well actually the hook could be maybe
right now moved into the part before kernel oops which is much less
frequently executed, but then it'll likely move up again once
kprobes support user space probes.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Rusty Lynch <rusty@linux.intel.com>,
"Lynch, Rusty" <rusty.lynch@intel.com>,
linux-mm@kvack.org, prasanna@in.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Date: Wed, 31 Aug 2005 02:05:00 +0200 [thread overview]
Message-ID: <200508310205.00965.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0508301642570.20548@schroedinger.engr.sgi.com>
On Wednesday 31 August 2005 01:54, Christoph Lameter wrote:
> Certainly not a big effect (if we make sure the compiler knows that
> this test mostly fails and insure that the variable is in
> __mostly_read)
Currently neither, but that could be easily fixed.
> but this is a frequently executed code path and the code
> is there without purpose if CONFIG_KPROBES is off.
Well if you really worry about it then it might be better to do some dynamic
code patching to make generic and distribution kernels too.
> It wont get too bad unless lots of other people have similar ideas about
> fixing their race conditions using similar methods. But we will be setting
> a bad precedent if we allow this.
Agreed on the general direction, but I didn't see an alternative
for kprobes for this. Well actually the hook could be maybe
right now moved into the part before kernel oops which is much less
frequently executed, but then it'll likely move up again once
kprobes support user space probes.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Rusty Lynch <rusty@linux.intel.com>,
"Lynch, Rusty" <rusty.lynch@intel.com>,
linux-mm@kvack.org, prasanna@in.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Date: Wed, 31 Aug 2005 02:05:00 +0200 [thread overview]
Message-ID: <200508310205.00965.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0508301642570.20548@schroedinger.engr.sgi.com>
On Wednesday 31 August 2005 01:54, Christoph Lameter wrote:
> Certainly not a big effect (if we make sure the compiler knows that
> this test mostly fails and insure that the variable is in
> __mostly_read)
Currently neither, but that could be easily fixed.
> but this is a frequently executed code path and the code
> is there without purpose if CONFIG_KPROBES is off.
Well if you really worry about it then it might be better to do some dynamic
code patching to make generic and distribution kernels too.
> It wont get too bad unless lots of other people have similar ideas about
> fixing their race conditions using similar methods. But we will be setting
> a bad precedent if we allow this.
Agreed on the general direction, but I didn't see an alternative
for kprobes for this. Well actually the hook could be maybe
right now moved into the part before kernel oops which is much less
frequently executed, but then it'll likely move up again once
kprobes support user space probes.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-08-31 0:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-25 20:14 [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES Christoph Lameter
2005-08-25 20:14 ` [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured Christoph Lameter
2005-08-30 23:05 ` Luck, Tony
2005-08-30 23:05 ` Luck, Tony
2005-08-30 23:05 ` Luck, Tony
2005-08-30 23:38 ` Andi Kleen
2005-08-30 23:38 ` Andi Kleen
2005-08-30 23:38 ` Andi Kleen
2005-08-30 23:54 ` [PATCH] Only process_die notifier in ia64_do_page_fault if Christoph Lameter
2005-08-30 23:54 ` [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured Christoph Lameter
2005-08-30 23:54 ` Christoph Lameter
2005-08-31 0:05 ` Andi Kleen [this message]
2005-08-31 0:05 ` Andi Kleen
2005-08-31 0:05 ` Andi Kleen
2005-08-30 23:56 ` [PATCH] Only process_die notifier in ia64_do_page_fault if David S. Miller
2005-08-30 23:56 ` [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured., Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured David S. Miller, Andi Kleen
2005-08-30 23:56 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-08-26 22:46 Rusty Lynch
2005-08-26 23:05 ` Re:[PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES Christoph Lameter
2005-08-27 0:24 ` [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured Andi Kleen
2005-08-27 0:24 ` Andi Kleen
2005-08-27 0:24 ` Andi Kleen
2005-08-30 0:19 ` Rusty Lynch
2005-08-30 0:19 ` Rusty Lynch
2005-08-30 0:19 ` Rusty Lynch
2005-08-30 1:08 ` Andi Kleen
2005-08-30 1:08 ` Andi Kleen
2005-08-30 1:08 ` Andi Kleen
2005-08-30 3:28 ` Christoph Lameter
2005-08-30 3:28 ` Christoph Lameter
2005-08-30 11:18 ` Matthew Wilcox
2005-08-30 11:18 ` Matthew Wilcox
2005-08-30 11:18 ` Matthew Wilcox
2005-09-19 18:22 ` Christoph Lameter
2005-09-19 18:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508310205.00965.ak@suse.de \
--to=ak@suse.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=clameter@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=prasanna@in.ibm.com \
--cc=rusty.lynch@intel.com \
--cc=rusty@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.