All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SCSI: Don't be so verbose if no disc is present
@ 2005-09-09 22:17 Daniel Drake
  2005-09-09 22:35 ` Patrick Mansfield
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Drake @ 2005-09-09 22:17 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Running a simple "touch /dev/scd0" on a SCSI cdrom will cause the following 
message to appear in the logs if no disc is present:

	Device not ready. Make sure there is a disc in the drive.

This results in the logs being flooded for some users by those userspace 
agents which repeatedly poll the device for media change.

This patch demotes the message to a quieter scsi-logging message only.

Signed-off-by: Daniel Drake <dsd@gentoo.org>


[-- Attachment #2: scsi-quiet-no-cd-warning.patch --]
[-- Type: text/x-patch, Size: 612 bytes --]

--- linux/drivers/scsi/scsi_ioctl.c.orig	2005-09-09 23:10:07.000000000 +0100
+++ linux/drivers/scsi/scsi_ioctl.c	2005-09-09 23:13:17.000000000 +0100
@@ -118,8 +118,9 @@ static int ioctl_internal_command(struct
 			break;
 		case NOT_READY:	/* This happens if there is no disc in drive */
 			if (sdev->removable && (cmd[0] != TEST_UNIT_READY)) {
-				printk(KERN_INFO "Device not ready. Make sure"
-				       " there is a disc in the drive.\n");
+				SCSI_LOG_IOCTL(2, printk(
+				       "Device not ready. Make sure"
+				       " there is a disc in the drive.\n"));
 				break;
 			}
 		case UNIT_ATTENTION:

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] SCSI: Don't be so verbose if no disc is present
  2005-09-09 22:17 [PATCH] SCSI: Don't be so verbose if no disc is present Daniel Drake
@ 2005-09-09 22:35 ` Patrick Mansfield
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick Mansfield @ 2005-09-09 22:35 UTC (permalink / raw)
  To: Daniel Drake; +Cc: James.Bottomley, linux-scsi

Hi ... did you try James' patch? Looks like the same problem.

Patch here:

http://marc.theaimsgroup.com/?l=linux-scsi&m=112585164819923&w=2

Was hidden within some other thread ...

On Fri, Sep 09, 2005 at 11:17:16PM +0100, Daniel Drake wrote:
> Running a simple "touch /dev/scd0" on a SCSI cdrom will cause the following 
> message to appear in the logs if no disc is present:
> 
> 	Device not ready. Make sure there is a disc in the drive.
> 
> This results in the logs being flooded for some users by those userspace 
> agents which repeatedly poll the device for media change.
> 
> This patch demotes the message to a quieter scsi-logging message only.
> 
> Signed-off-by: Daniel Drake <dsd@gentoo.org>
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-09 22:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-09 22:17 [PATCH] SCSI: Don't be so verbose if no disc is present Daniel Drake
2005-09-09 22:35 ` Patrick Mansfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.