From: "John W. Linville" <linville@tuxdriver.com>
To: Grant Grundler <iod00d@hp.com>
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
linux-ia64@vger.kernel.org, ak@suse.de, tony.luck@intel.com,
Asit.K.Mallick@intel.com
Subject: [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single
Date: Mon, 12 Sep 2005 19:53:56 +0000 [thread overview]
Message-ID: <20050912195356.GD19644@tuxdriver.com> (raw)
In-Reply-To: <20050912195110.GC19644@tuxdriver.com>
Call BUG() if DMA_NONE is passed-in as direction for sync_single.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
lib/swiotlb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -315,13 +315,13 @@ sync_single(struct device *hwdev, char *
case SYNC_FOR_CPU:
if (likely(dir = DMA_FROM_DEVICE || dma = DMA_BIDIRECTIONAL))
memcpy(buffer, dma_addr, size);
- else if (dir != DMA_TO_DEVICE && dir != DMA_NONE)
+ else if (dir != DMA_TO_DEVICE)
BUG();
break;
case SYNC_FOR_DEVICE:
if (likely(dir = DMA_TO_DEVICE || dma = DMA_BIDIRECTIONAL))
memcpy(dma_addr, buffer, size);
- else if (dir != DMA_FROM_DEVICE && dir != DMA_NONE)
+ else if (dir != DMA_FROM_DEVICE)
BUG();
break;
default:
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Grant Grundler <iod00d@hp.com>
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
linux-ia64@vger.kernel.org, ak@suse.de, tony.luck@intel.com,
Asit.K.Mallick@intel.com
Subject: [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single
Date: Mon, 12 Sep 2005 15:53:56 -0400 [thread overview]
Message-ID: <20050912195356.GD19644@tuxdriver.com> (raw)
In-Reply-To: <20050912195110.GC19644@tuxdriver.com>
Call BUG() if DMA_NONE is passed-in as direction for sync_single.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
lib/swiotlb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -315,13 +315,13 @@ sync_single(struct device *hwdev, char *
case SYNC_FOR_CPU:
if (likely(dir == DMA_FROM_DEVICE || dma == DMA_BIDIRECTIONAL))
memcpy(buffer, dma_addr, size);
- else if (dir != DMA_TO_DEVICE && dir != DMA_NONE)
+ else if (dir != DMA_TO_DEVICE)
BUG();
break;
case SYNC_FOR_DEVICE:
if (likely(dir == DMA_TO_DEVICE || dma == DMA_BIDIRECTIONAL))
memcpy(dma_addr, buffer, size);
- else if (dir != DMA_FROM_DEVICE && dir != DMA_NONE)
+ else if (dir != DMA_FROM_DEVICE)
BUG();
break;
default:
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-09-12 19:53 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-29 20:09 [patch 2.6.13] x86_64: implement dma_sync_single_range_for_{cpu,device} John W. Linville
2005-08-29 20:54 ` Andi Kleen
2005-08-29 21:48 ` John W. Linville
2005-08-30 1:14 ` [discuss] " Andi Kleen
2005-08-30 17:54 ` John W. Linville
2005-08-30 17:58 ` [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device} John W. Linville
2005-08-30 17:58 ` John W. Linville
2005-08-30 18:00 ` [patch 2.6.13] x86_64: implement dma_sync_single_range_for_{cpu,device} John W. Linville
2005-08-30 18:03 ` [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device} Luck, Tony
2005-08-30 18:03 ` Luck, Tony
2005-08-30 18:09 ` John W. Linville
2005-08-30 18:09 ` John W. Linville
2005-08-30 18:33 ` [rfc patch] swiotlb: consolidate swiotlb_sync_single_* implementations John W. Linville
2005-08-30 18:33 ` John W. Linville
2005-08-30 18:40 ` [rfc patch] swiotlb: consolidate swiotlb_sync_sg_* implementations John W. Linville
2005-08-30 18:40 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 1/6] swiotlb: move from arch/ia64/lib to lib John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 5/6] swiotlb: file header comments John W. Linville
2005-09-12 14:48 ` John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 6/6] x86_64: implement dma_sync_single_range_for_{cpu,device} John W. Linville
2005-09-12 15:22 ` Andi Kleen
2005-09-12 18:51 ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings Grant Grundler
2005-09-12 18:51 ` Grant Grundler
2005-09-12 19:51 ` John W. Linville
2005-09-12 19:51 ` John W. Linville
2005-09-12 19:53 ` John W. Linville [this message]
2005-09-12 19:53 ` [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single John W. Linville
2005-09-12 20:23 ` Grant Grundler
2005-09-12 20:23 ` Grant Grundler
2005-09-12 23:45 ` [patch 2.6.13 (take #2)] " John W. Linville
2005-09-12 23:45 ` John W. Linville
2005-09-12 23:59 ` Grant Grundler
2005-09-12 23:59 ` Grant Grundler
2005-09-13 4:05 ` [discuss] " Andi Kleen
2005-09-13 4:05 ` Andi Kleen
2005-09-22 20:37 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
2005-09-22 20:37 ` Luck, Tony
2005-09-22 20:41 ` Christoph Hellwig
2005-09-22 20:41 ` Christoph Hellwig
2005-09-23 18:22 ` John W. Linville
2005-09-23 18:22 ` John W. Linville
2005-09-23 18:31 ` Muli Ben-Yehuda
2005-09-23 18:31 ` Muli Ben-Yehuda
2005-09-23 18:27 ` Luck, Tony
2005-09-23 18:27 ` Luck, Tony
2005-09-23 18:50 ` John W. Linville
2005-09-23 18:50 ` John W. Linville
2005-09-23 21:38 ` Grant Grundler
2005-09-23 21:38 ` Grant Grundler
2005-09-26 7:01 ` Andi Kleen
2005-09-26 7:01 ` Andi Kleen
2005-09-26 21:01 ` [patch 2.6.14-rc2 0/5] " John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 1/5] swiotlb: move from arch/ia64/lib to drivers/pci John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 2/5] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 3/5] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 4/5] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 5/5] swiotlb: file header comments John W. Linville
2005-09-26 21:01 ` John W. Linville
2005-09-26 21:33 ` [patch 2.6.14-rc2 0/5] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Matthew Wilcox
2005-09-26 21:33 ` Matthew Wilcox
2005-09-26 21:54 ` John W. Linville
2005-09-26 21:54 ` John W. Linville
2005-09-26 22:08 ` Luck, Tony
2005-09-26 22:08 ` Luck, Tony
2005-09-26 22:46 ` Grant Grundler
2005-09-26 22:46 ` Grant Grundler
2005-09-27 0:14 ` John W. Linville
2005-09-27 0:14 ` John W. Linville
2005-09-27 2:47 ` Tony Luck
2005-09-27 2:47 ` Tony Luck
2005-09-28 21:50 ` [patch 2.6.14-rc2 0/6] " John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 1/6] swiotlb: move from arch/ia64/lib/ to lib/ John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 5/6] swiotlb: file header comments John W. Linville
2005-09-28 21:50 ` John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 6/6] x86_64: implement dma_sync_single_range_for_{cpu,device} John W. Linville
2005-09-29 22:42 ` [patch 2.6.14-rc2 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
2005-09-29 22:42 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050912195356.GD19644@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Asit.K.Mallick@intel.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=iod00d@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.