From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [discuss] Re: [Patch] x86, x86_64: Intel HT, Multi core detection code cleanup
Date: Sat, 8 Oct 2005 12:28:38 +0200 [thread overview]
Message-ID: <200510081228.39492.ak@suse.de> (raw)
In-Reply-To: <20051007175240.A2354@unix-os.sc.intel.com>
On Saturday 08 October 2005 02:52, Siddha, Suresh B wrote:
> On Fri, Oct 07, 2005 at 11:52:00AM +0200, Andi Kleen wrote:
> > > I can fix the API mess. Is there anything else you want me to do?
> >
> > I think you overdid the sharing. Can you limit it to one file
> > and copy the stuff that doesn't fit easily?
>
> Andi, This stuff is very much common to x86 and x86_64. Shared code is
> split into two files because setting up sibling map code is generic and
> HT/core detection code is very specific to Intel.
>
> How about the appended patch?
I would prefer if the Intel CPU detection support wasn't distributed over so
many small files. If you prefer to share it put it all into a single file and
share that. But please only for code that can be cleanly shared without
ifdefs.
Also in general it would be better if you first did the cleanup and then
as separate patches the various functionality enhancements.That makes
the changes easier to be reviewed and it helps in binary search when something
goes wrong.
-Andi
next prev parent reply other threads:[~2005-10-08 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 23:17 [Patch] x86, x86_64: Intel HT, Multi core detection code cleanup Siddha, Suresh B
2005-10-06 10:42 ` Andi Kleen
2005-10-07 2:20 ` Siddha, Suresh B
2005-10-07 9:52 ` [discuss] " Andi Kleen
2005-10-08 0:52 ` Siddha, Suresh B
2005-10-08 10:28 ` Andi Kleen [this message]
2005-10-12 21:30 ` Siddha, Suresh B
2005-10-12 21:36 ` [Patch 1/2] x86, x86_64: Intel HT, Multi core detection fixes Siddha, Suresh B
2005-10-12 21:49 ` [discuss] " Andi Kleen
2005-10-12 22:19 ` Siddha, Suresh B
2005-10-13 0:10 ` Andi Kleen
2005-10-13 21:55 ` Siddha, Suresh B
2005-10-13 21:59 ` [Patch 2/2] x86, x86_64: fix Intel cache detection code assumption about threads sharing Siddha, Suresh B
2005-10-12 21:41 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510081228.39492.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.