All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] befs: use generic_ro_fops
@ 2005-10-31 23:35 Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2005-10-31 23:35 UTC (permalink / raw)
  To: akpm, rathamahata; +Cc: linux-fsdevel

no need to duplicate a generic readonly file ops table in befs.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/befs/linuxvfs.c
===================================================================
--- linux-2.6.orig/fs/befs/linuxvfs.c	2005-10-31 12:23:55.000000000 +0100
+++ linux-2.6/fs/befs/linuxvfs.c	2005-10-31 15:02:12.000000000 +0100
@@ -73,12 +73,6 @@
 	.lookup		= befs_lookup,
 };
 
-static struct file_operations befs_file_operations = {
-	.llseek		= default_llseek,
-	.read		= generic_file_read,
-	.mmap		= generic_file_readonly_mmap,
-};
-
 static struct address_space_operations befs_aops = {
 	.readpage	= befs_readpage,
 	.sync_page	= block_sync_page,
@@ -398,7 +392,7 @@
 	inode->i_mapping->a_ops = &befs_aops;
 
 	if (S_ISREG(inode->i_mode)) {
-		inode->i_fop = &befs_file_operations;
+		inode->i_fop = &generic_ro_fops;
 	} else if (S_ISDIR(inode->i_mode)) {
 		inode->i_op = &befs_dir_inode_operations;
 		inode->i_fop = &befs_dir_operations;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-10-31 23:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-31 23:35 [PATCH] befs: use generic_ro_fops Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.