* [PATCH] Prevent vbd frontend from oopsing if the underlying device doesn't exist
@ 2005-12-26 8:55 Horms
2005-12-27 15:31 ` Vincent Hanquez
0 siblings, 1 reply; 2+ messages in thread
From: Horms @ 2005-12-26 8:55 UTC (permalink / raw)
To: xen-devel
Prevent vbd frontend from oopsing if the underlying device doesn't exist.
connect() in blkfront.c was not checking the return value of xlvbd_add().
In my case xlvbd_alloc_gendisk() was failing in xlvbd_add(), and the
subsequent call to kick_pending_request_queues() barfed because info->rq
was unitinialised.
Signed-Off-By: Horms <horms@verge.net.au>
diff -r e3b95be182e2 -r 9c36c9568da0 linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c Thu Dec 22 03:30:14 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c Mon Dec 26 08:52:20 2005
@@ -338,7 +338,12 @@
return;
}
- xlvbd_add(sectors, info->vdevice, binfo, sector_size, info);
+ err = xlvbd_add(sectors, info->vdevice, binfo, sector_size, info);
+ if (err) {
+ xenbus_dev_fatal(info->xbdev, err, "xlvbd_add at %s",
+ info->xbdev->otherend);
+ return;
+ }
(void)xenbus_switch_state(info->xbdev, NULL, XenbusStateConnected);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-12-27 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-26 8:55 [PATCH] Prevent vbd frontend from oopsing if the underlying device doesn't exist Horms
2005-12-27 15:31 ` Vincent Hanquez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.