All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
To: Jacob Gorm Hansen <jacobg@diku.dk>
Cc: xen-devel@lists.xensource.com
Subject: Re: smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP
Date: Mon, 9 Jan 2006 23:32:31 +0100	[thread overview]
Message-ID: <20060109223231.GA32395@snarc.org> (raw)
In-Reply-To: <e08041f30601030220rdad85b5g6a5efb0a52f2bf74@mail.gmail.com>

On Tue, Jan 03, 2006 at 11:20:57AM +0100, Jacob Gorm Hansen wrote:
> I found I needed the patch to arch/i386/kernel/i8237.c below in order
> to compile linux-2.6-xen.hg without SMP, or I smp_processor_id() would
> be undefined. I am not sure if this is the correct way to fix the
> problem though.

This is not the right fix. (hint: i8237 is not modified by xen and has
nothing to do with smp)
Unfortunately, properly fixing the bug is not trivial.

basicly linux/smp.h has to be included before xen's system.h get
included for the compilation to succeed. As the i386 kernel
doesn't need this assertion, it's not working for i8237..

I tried a couple of things, but they all lead to some funky errors ..

-- 
Vincent Hanquez

      parent reply	other threads:[~2006-01-09 22:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03 10:20 smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP Jacob Gorm Hansen
2006-01-06 22:40 ` Thomas Schwinge
2006-01-09 22:32 ` Vincent Hanquez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060109223231.GA32395@snarc.org \
    --to=vincent.hanquez@cl.cam.ac.uk \
    --cc=jacobg@diku.dk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.