smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP

smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP

[Jacob Gorm Hansen]

hi,

I found I needed the patch to arch/i386/kernel/i8237.c below in order
to compile linux-2.6-xen.hg without SMP, or I smp_processor_id() would
be undefined. I am not sure if this is the correct way to fix the
problem though.

best regards,
Jacob

$ hg diff arch/i386/kernel/i8237.c
diff -r e0881feac5b9 arch/i386/kernel/i8237.c
--- a/arch/i386/kernel/i8237.c  Thu Dec 22 17:28:39 2005
+++ b/arch/i386/kernel/i8237.c  Tue Jan  3 11:20:22 2006
@@ -7,6 +7,7 @@
 #include <linux/init.h>
 #include <linux/sysdev.h>

+#include <linux/smp.h>
 #include <asm/dma.h>

 /*

Re: smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP

[Thomas Schwinge]

Hi!

Building <URL:http://xenbits.xensource.com/linux-2.6-xen.hg> with a
custom .config without SMP support for example, fails like this for me:

#v+
[...]
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/i386/kernel/built-in.o: In function `i8237A_resume':
i8237.c:(.text+0x9d59): undefined reference to `smp_processor_id'
i8237.c:(.text+0x9dbf): undefined reference to `smp_processor_id'
make: *** [.tmp_vmlinux1] Error 1
#v-


On Tue, Jan 03, 2006 at 11:20:57AM +0100, Jacob Gorm Hansen wrote:
> I found I needed the patch to arch/i386/kernel/i8237.c below in order
> to compile linux-2.6-xen.hg without SMP, or I smp_processor_id() would
> be undefined. I am not sure if this is the correct way to fix the
> problem though.

> $ hg diff arch/i386/kernel/i8237.c
> diff -r e0881feac5b9 arch/i386/kernel/i8237.c
> --- a/arch/i386/kernel/i8237.c  Thu Dec 22 17:28:39 2005
> +++ b/arch/i386/kernel/i8237.c  Tue Jan  3 11:20:22 2006
> @@ -7,6 +7,7 @@
>  #include <linux/init.h>
>  #include <linux/sysdev.h>
> 
> +#include <linux/smp.h>
>  #include <asm/dma.h>
> 
>  /*

This patch also fixes the problem for me.


Regards,
 Thomas

Re: smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP

[Vincent Hanquez]

On Tue, Jan 03, 2006 at 11:20:57AM +0100, Jacob Gorm Hansen wrote:
> I found I needed the patch to arch/i386/kernel/i8237.c below in order
> to compile linux-2.6-xen.hg without SMP, or I smp_processor_id() would
> be undefined. I am not sure if this is the correct way to fix the
> problem though.

This is not the right fix. (hint: i8237 is not modified by xen and has
nothing to do with smp)
Unfortunately, properly fixing the bug is not trivial.

basicly linux/smp.h has to be included before xen's system.h get
included for the compilation to succeed. As the i386 kernel
doesn't need this assertion, it's not working for i8237..

I tried a couple of things, but they all lead to some funky errors ..

-- 
Vincent Hanquez