* Re: [PATCH] Introduce __iowrite32_copy [not found] <200602011820.k11IKUBo024575@hera.kernel.org> @ 2006-02-02 14:29 ` Olaf Hering 2006-02-02 14:57 ` Heiko Carstens 0 siblings, 1 reply; 5+ messages in thread From: Olaf Hering @ 2006-02-02 14:29 UTC (permalink / raw) To: Martin Schwidefsky, Bryan O'Sullivan; +Cc: linux-kernel On Wed, Feb 01, Linux Kernel Mailing List wrote: > tree c4d797b413bb6f8a1b8507213294a291ab5114f8 > parent f7589f28d7dd4586b4e90ac3b2a180409669053a > author Bryan O'Sullivan <bos@pathscale.com> Wed, 01 Feb 2006 19:05:16 -0800 > committer Linus Torvalds <torvalds@g5.osdl.org> Thu, 02 Feb 2006 00:53:13 -0800 > > [PATCH] Introduce __iowrite32_copy > > This arch-independent routine copies data to a memory-mapped I/O region, > using 32-bit accesses. The naming is double-underscored to make it clear > that it does not guarantee write ordering, nor does it perform a memory > barrier afterwards; the kernel doc also explicitly states this. This style > of access is required by some devices. > > This change also introduces include/linux/io.h, at Andrew's suggestion. It > only has one occupant at the moment, but is a logical destination for > oft-replicated contents of include/asm-*/{io,iomap}.h to migrate to. > +++ b/lib/iomap_copy.c > +void __attribute__((weak)) __iowrite32_copy(void __iomem *to, > + const void *from, > + size_t count) > +{ > + u32 __iomem *dst = to; > + const u32 *src = from; > + const u32 *end = src + count; > + > + while (src < end) > + __raw_writel(*src++, dst++); > +} lib/iomap_copy.c: In function '__iowrite32_copy': lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel' We compile with -Werror-implicit-function-declaration, and s390 does not have a __raw_writel. Should it just define __raw_writel to writel, like uml does a few commits later? -- short story of a lazy sysadmin: alias appserv=wotan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Introduce __iowrite32_copy 2006-02-02 14:29 ` [PATCH] Introduce __iowrite32_copy Olaf Hering @ 2006-02-02 14:57 ` Heiko Carstens 2006-02-02 16:49 ` Bryan O'Sullivan 2006-02-03 6:30 ` Al Viro 0 siblings, 2 replies; 5+ messages in thread From: Heiko Carstens @ 2006-02-02 14:57 UTC (permalink / raw) To: Olaf Hering; +Cc: Martin Schwidefsky, Bryan O'Sullivan, linux-kernel > lib/iomap_copy.c: In function '__iowrite32_copy': > lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel' > > We compile with -Werror-implicit-function-declaration, and s390 does not > have a __raw_writel. > Should it just define __raw_writel to writel, like uml does a few > commits later? I sent a patch which fixes this for s390 earlier today. http://lkml.org/lkml/2006/2/2/78 Thanks, Heiko ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Introduce __iowrite32_copy 2006-02-02 14:57 ` Heiko Carstens @ 2006-02-02 16:49 ` Bryan O'Sullivan 2006-02-03 6:30 ` Al Viro 1 sibling, 0 replies; 5+ messages in thread From: Bryan O'Sullivan @ 2006-02-02 16:49 UTC (permalink / raw) To: Heiko Carstens; +Cc: Olaf Hering, Martin Schwidefsky, linux-kernel On Thu, 2006-02-02 at 15:57 +0100, Heiko Carstens wrote: > I sent a patch which fixes this for s390 earlier today. > http://lkml.org/lkml/2006/2/2/78 Thanks. <b ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Introduce __iowrite32_copy 2006-02-02 14:57 ` Heiko Carstens 2006-02-02 16:49 ` Bryan O'Sullivan @ 2006-02-03 6:30 ` Al Viro 2006-02-03 8:34 ` Kars de Jong 1 sibling, 1 reply; 5+ messages in thread From: Al Viro @ 2006-02-03 6:30 UTC (permalink / raw) To: Heiko Carstens Cc: Olaf Hering, Martin Schwidefsky, Bryan O'Sullivan, linux-kernel, linux-m68k On Thu, Feb 02, 2006 at 03:57:20PM +0100, Heiko Carstens wrote: > > lib/iomap_copy.c: In function '__iowrite32_copy': > > lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel' > > > > We compile with -Werror-implicit-function-declaration, and s390 does not > > have a __raw_writel. > > Should it just define __raw_writel to writel, like uml does a few > > commits later? > > I sent a patch which fixes this for s390 earlier today. > http://lkml.org/lkml/2006/2/2/78 Which leaves mips, m68k and sh64... For m68k cross-builds I've added #define __raw_writel raw_outl in raw_io.h, but I'm not sure if m68k folks are OK with that. Comments? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Introduce __iowrite32_copy 2006-02-03 6:30 ` Al Viro @ 2006-02-03 8:34 ` Kars de Jong 0 siblings, 0 replies; 5+ messages in thread From: Kars de Jong @ 2006-02-03 8:34 UTC (permalink / raw) To: Al Viro Cc: linux-m68k, linux-kernel, Bryan O'Sullivan, Martin Schwidefsky, Olaf Hering, Heiko Carstens On vr, 2006-02-03 at 06:30 +0000, Al Viro wrote: > On Thu, Feb 02, 2006 at 03:57:20PM +0100, Heiko Carstens wrote: > > > lib/iomap_copy.c: In function '__iowrite32_copy': > > > lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel' > > > > > > We compile with -Werror-implicit-function-declaration, and s390 does not > > > have a __raw_writel. > > > Should it just define __raw_writel to writel, like uml does a few > > > commits later? > > > > I sent a patch which fixes this for s390 earlier today. > > http://lkml.org/lkml/2006/2/2/78 > > Which leaves mips, m68k and sh64... For m68k cross-builds I've added > #define __raw_writel raw_outl in raw_io.h, but I'm not sure if m68k > folks are OK with that. Comments? That's exactly what I have done in my local tree for the 53c700 driver which uses the interfaces of lib/iomap.c, so it's fine with me. Kind regards, Kars. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-02-03 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200602011820.k11IKUBo024575@hera.kernel.org>
2006-02-02 14:29 ` [PATCH] Introduce __iowrite32_copy Olaf Hering
2006-02-02 14:57 ` Heiko Carstens
2006-02-02 16:49 ` Bryan O'Sullivan
2006-02-03 6:30 ` Al Viro
2006-02-03 8:34 ` Kars de Jong
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.