Two comments on the H.323 conntrack/NAT helper

Two comments on the H.323 conntrack/NAT helper

[Adrian Bunk]

Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are _ugly_,
  please move them to a header file
- is there a reason for not using EXPORT_SYMBOL_GPL?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Two comments on the H.323 conntrack/NAT helper

[Adrian Bunk]

Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are _ugly_,
  please move them to a header file
- is there a reason for not using EXPORT_SYMBOL_GPL?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Two comments on the H.323 conntrack/NAT helper

[Patrick McHardy]

[The hotmail address of the author doesn't work, CCed sourceforge-address]

Adrian Bunk wrote:
> Two comments on the H.323 conntrack/NAT helper:
> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>   please move them to a header file

Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.

> - is there a reason for not using EXPORT_SYMBOL_GPL?

I would prefer that too.

Re: Two comments on the H.323 conntrack/NAT helper

[Patrick McHardy]

[The hotmail address of the author doesn't work, CCed sourceforge-address]

Adrian Bunk wrote:
> Two comments on the H.323 conntrack/NAT helper:
> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>   please move them to a header file

Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.

> - is there a reason for not using EXPORT_SYMBOL_GPL?

I would prefer that too.

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>; <zhaojingmin@users.sourceforge.net>; 
<netfilter-devel@lists.netfilter.org>; "Jing Min Zhao" 
<zhaojignmin@hotmail.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> [The hotmail address of the author doesn't work, CCed sourceforge-address]
>
> Adrian Bunk wrote:
>> Two comments on the H.323 conntrack/NAT helper:
>> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>>   please move them to a header file
>
> Their ugliness is because of the current API, which cleaned up
> quite a lot of the surrounding code, but requires this ugliness
> from each helper. I would like to keep them visible as a reminder
> that a cleaner solution is wanted, but moving them to header
> files certainly sound like a good idea to eliminate the risk
> of prototype conflicts. But please do this for all helpers
> at once.
>
>> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
> I would prefer that too.
>
>

Sure, I'll do that.

Thanks

Jing Min Zhao 

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>; <zhaojingmin@users.sourceforge.net>; 
<netfilter-devel@lists.netfilter.org>; "Jing Min Zhao" 
<zhaojignmin@hotmail.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> [The hotmail address of the author doesn't work, CCed sourceforge-address]
>
> Adrian Bunk wrote:
>> Two comments on the H.323 conntrack/NAT helper:
>> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>>   please move them to a header file
>
> Their ugliness is because of the current API, which cleaned up
> quite a lot of the surrounding code, but requires this ugliness
> from each helper. I would like to keep them visible as a reminder
> that a cleaner solution is wanted, but moving them to header
> files certainly sound like a good idea to eliminate the risk
> of prototype conflicts. But please do this for all helpers
> at once.
>
>> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
> I would prefer that too.
>
>

Sure, I'll do that.

Thanks

Jing Min Zhao 

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>; <zhaojingmin@users.sourceforge.net>; <netfilter-devel@lists.netfilter.org>; "Jing Min Zhao" 
<zhaojignmin@hotmail.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> [The hotmail address of the author doesn't work, CCed sourceforge-address]
>
> Adrian Bunk wrote:
>> Two comments on the H.323 conntrack/NAT helper:
>> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>>   please move them to a header file
>
> Their ugliness is because of the current API, which cleaned up
> quite a lot of the surrounding code, but requires this ugliness
> from each helper. I would like to keep them visible as a reminder
> that a cleaner solution is wanted, but moving them to header
> files certainly sound like a good idea to eliminate the risk
> of prototype conflicts. But please do this for all helpers
> at once.
>
>> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
> I would prefer that too.
>
>

I've moved those prototypes. But the move involves moving of two header files:
ip_conntrack_helper_h323_asn1.h and ip_conntrack_helper_h323_types.h.
This is because ip_conntrack_h323.h now has to include
ip_conntrack_helper_h323_asn1.h and thus ip_conntrack_helper_h323_types.h,
so they are moved from net/ipv4/netfilter/ to include/linux/netfilter_ipv4/ to
make sure other header files like ip_conntrack_h323.h and ip_conntrack.h
be able to find them.

Is this ok or you have a better idea?

Thanks a lot!

Jing Min Zhao

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>; <zhaojingmin@users.sourceforge.net>; <netfilter-devel@lists.netfilter.org>; "Jing Min Zhao" 
<zhaojignmin@hotmail.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> [The hotmail address of the author doesn't work, CCed sourceforge-address]
>
> Adrian Bunk wrote:
>> Two comments on the H.323 conntrack/NAT helper:
>> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>>   please move them to a header file
>
> Their ugliness is because of the current API, which cleaned up
> quite a lot of the surrounding code, but requires this ugliness
> from each helper. I would like to keep them visible as a reminder
> that a cleaner solution is wanted, but moving them to header
> files certainly sound like a good idea to eliminate the risk
> of prototype conflicts. But please do this for all helpers
> at once.
>
>> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
> I would prefer that too.
>
>

I've moved those prototypes. But the move involves moving of two header files:
ip_conntrack_helper_h323_asn1.h and ip_conntrack_helper_h323_types.h.
This is because ip_conntrack_h323.h now has to include
ip_conntrack_helper_h323_asn1.h and thus ip_conntrack_helper_h323_types.h,
so they are moved from net/ipv4/netfilter/ to include/linux/netfilter_ipv4/ to
make sure other header files like ip_conntrack_h323.h and ip_conntrack.h
be able to find them.

Is this ok or you have a better idea?

Thanks a lot!

Jing Min Zhao

Re: Two comments on the H.323 conntrack/NAT helper

[Patrick McHardy]

Jing Min Zhao wrote:
> I've moved those prototypes. But the move involves moving of two header
> files:
> ip_conntrack_helper_h323_asn1.h and ip_conntrack_helper_h323_types.h.
> This is because ip_conntrack_h323.h now has to include
> ip_conntrack_helper_h323_asn1.h and thus ip_conntrack_helper_h323_types.h,
> so they are moved from net/ipv4/netfilter/ to
> include/linux/netfilter_ipv4/ to
> make sure other header files like ip_conntrack_h323.h and ip_conntrack.h
> be able to find them.
> 
> Is this ok or you have a better idea?

I can't think of a better solution as long as we have the typedefs.

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]


----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Jing Min Zhao" <zhaojingmin@hotmail.com>
Cc: <netfilter-devel@lists.netfilter.org>; <zhaojingmin@users.sourceforge.net>
Sent: Wednesday, March 29, 2006 5:09 AM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> Jing Min Zhao wrote:
>> I've moved those prototypes. But the move involves moving of two header
>> files:
>> ip_conntrack_helper_h323_asn1.h and ip_conntrack_helper_h323_types.h.
>> This is because ip_conntrack_h323.h now has to include
>> ip_conntrack_helper_h323_asn1.h and thus ip_conntrack_helper_h323_types.h,
>> so they are moved from net/ipv4/netfilter/ to
>> include/linux/netfilter_ipv4/ to
>> make sure other header files like ip_conntrack_h323.h and ip_conntrack.h
>> be able to find them.
>> 
>> Is this ok or you have a better idea?
> 
> I can't think of a better solution as long as we have the typedefs.
> 
>

This is the new release against 2.6.16. 

Changes:

1. Added new parameter "default_rrq_ttl". This is used to specify a default
timeToLive (in seconds) for registering an endpoint that doesn't send 
keep-alive RRQ and there is no timeToLive in RRQ and RCF. In this
situation, normally the RAS connection and call signal expectation will 
expire quickly (udp connection expire in 180 seconds by default). This may 
not be what people want when they register endpoints for receiving calls. 
By setting this parameter to a longer time, such endpoints like Netmeeting 
can register once and stay alive for a longer time to receive calls from outside
of firewall. The default value is 300 (seconds).

2. Moved some extern function prototypes to ip_conntrack_h323.h  
(suggested by Adrian Bunk)

3. Made get_h245_addr static (suggested by Adrian Bunk) 
 
4. Changed to use EXPORT_SYMBOL_GPL (suggested by Adrian Bunk) 


Best regards,

Jing Min Zhao


Signed-off-by: Jing Min Zhao <zhaojingmin@hotmail.com>

[-- Attachment #2: patch-2.6.16-nath323-0.7.bz2 --]
[-- Type: application/octet-stream, Size: 26858 bytes --]

Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Adrian Bunk" <bunk@stusta.de>
To: "Jing Min Zhao" <zhaojignmin@hotmail.com>
Cc: <netdev@vger.kernel.org>; <netfilter-devel@lists.netfilter.org>; 
<linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 7:13 PM
Subject: Two comments on the H.323 conntrack/NAT helper


> Two comments on the H.323 conntrack/NAT helper:
Thank you for your advice.

> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>  please move them to a header file
Correct, I'll do that.

> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
No, I just forgot it. I'll change this too.

> cu
Hope I can get more advice from you.

> Adrian
>
> -- 
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
That's Hepburn :-)

>
>